Bug - Fixed mall search gives inaccurate results [v28317]

[Bombastus]

mallsearch in Mafia gCLI:


mallsearch in the relay browser (which is fed by mafia, I am most confused):

 

[Veracity]

You'd prefer this:

> searchmall Pack of Every Card

Searching for "Pack of Every Card"...
Search complete.
1 @ 4,995,000,000 meat
1 @ 5,750,000,000 meat
1 @ 6,999,999,998 meat
1 @ 7,999,000,000 meat

We forgot to change this when mall prices started to be "long" values.
Simple fix:

diff --git a/src/net/sourceforge/kolmafia/session/MallPriceManager.java b/src/net/sourceforge/kolmafia/session/MallPriceManager.java
index 2c4f2fd3b8..16fc5291a2 100644
--- a/src/net/sourceforge/kolmafia/session/MallPriceManager.java
+++ b/src/net/sourceforge/kolmafia/session/MallPriceManager.java
@@ -432,7 +432,7 @@ public abstract class MallPriceManager {
           "  "
               + KoLConstants.COMMA_FORMAT.format(prices.get(priceArray[i]).intValue())
               + " @ "
-              + KoLConstants.COMMA_FORMAT.format(priceArray[i].intValue())
+              + KoLConstants.COMMA_FORMAT.format(priceArray[i])
               + " meat");
     }
   }

 

[Crowther]

I knew it was getting retyped somewhere, but couldn't find it.

New Content - Implemented Post in thread 'Mall Cap Raised, Meat Cap Raised, Certain Mall Items Repriced'

Jan 4, 2025

I think this might be related, but it could be new.

Searching for "snowman-enchanting tophat"...
Search complete.
1    @ 74,999,999 meat
1 @ 77,900,000 meat
1 @ 80,000,000 meat
1 @    83,000,000 meat
1 @ 85,000,000 meat
1 @ 95,500,000 meat
2 @    100,000,000 meat
1 @ 123,000,000 meat
1 @ 175,000,000 meat
1 @    250,000,000 meat
1 @ 299,999,995 meat
1 @ 313,333,337 meat
1 @    420,690,000 meat
1 @ 999,999,999 meat
1 @ 1,000,000,000 meat
1 @    1,500,000,000 meat
1 @ -294,967,296 meat
1 @ 1,215,752,191 meat

The negative price should be 4 billion and the next price should be 14 nines...

• Crowther

 

[Veracity]

r28333