Bug - Not A Bug Mafia always updates internals for June Cleaver's choices, even when its the same choice.

I

Irrat

Member
I had the choices setup to select 4 (Skip) on the June Cleaver's NC, though I was out of skips.
This obviously didn't work.

But I noticed that the choice was being processed repeatedly, which would be a non-issue but that it was filling the queue with the same choice ID.

I think the solution would be to ignore the choice if its the same choice as last time, as afaik the NC's do not repeat.

Code: 
[605] The Dire Warren
Preference lastEncounter changed from War Hippy Infantryman to Delicious Sprouts
Encounter: Delicious Sprouts
Took choice 1474/4: Do nothing
choice.php?pwd&whichchoice=1474&option=4
Encounter: Delicious Sprouts
Preference juneCleaverQueue changed from 1468,1472,1473,1471,1470,1469 to 1472,1473,1471,1470,1469,1474
Preference _juneCleaverSkips changed from 5 to 6
Preference _juneCleaverFightsLeft changed from 0 to 8
> Visited choice.php?pwd=&whichchoice=1474&option=4
Took choice 1474/4: Do nothing
choice.php?pwd&whichchoice=1474&option=4
Encounter: Delicious Sprouts
Preference juneCleaverQueue changed from 1472,1473,1471,1470,1469,1474 to 1473,1471,1470,1469,1474,1474
Preference _juneCleaverSkips changed from 6 to 7
> Visited choice.php?pwd=&whichchoice=1474&option=4
Took choice 1474/4: Do nothing
choice.php?pwd&whichchoice=1474&option=4
Encounter: Delicious Sprouts
Preference juneCleaverQueue changed from 1473,1471,1470,1469,1474,1474 to 1471,1470,1469,1474,1474,1474
Preference _juneCleaverSkips changed from 7 to 8
> Visited choice.php?pwd=&whichchoice=1474&option=4
Took choice 1474/4: Do nothing
choice.php?pwd&whichchoice=1474&option=4
 
R

Ryo_Sangnoir

Developer
Staff member
Irrat said:
I had the choices setup to select 4 (Skip) on the June Cleaver's NC, though I was out of skips.
Click to expand...
What does it mean to be "out of skips"? This isn't something Mafia knows about.

By the wiki, seems to not allow you to skip after you've selected it 5 times.
 
I

Irrat

Member
Ryo_Sangnoir said:
What does it mean to be "out of skips"? This isn't something Mafia knows about.

By the wiki, seems to not allow you to skip after you've selected it 5 times.
Click to expand...

Sorry for the confusion.

I meant that I'd already skipped it 5 times, so I have no more skips available. Though I glitched and didn't recognize that in my script, and still tried to skip it despite not having a skip.

The skips isn't really relevant here.

It's more that I encounter choice 1474, mafia updates the preferences for June Cleaver. I tried to skip, redirected back to the choice, mafia thinks its a new june cleaver NC and updates the preferences again.
 
Veracity

Veracity

Developer
Staff member
If can no longer skip because you’ve done 5 today, does KoL still show the option to skip? If so, what does it say when you take it? If not, it would not show up in available_choice_options() and it is arguably a bug that your script doesn’t check.

How are you submitting that? visit_url()? run_choice()?

The former would be (erroneous) raw URL injection. The latter is one step away from that and we could certainly check available choices and reject it.
 
I

Irrat

Member
Yeah, just checked and you're correct, I can't seem to reproduce without visit_url. Sorry for the trouble.
 
You must log in or register to reply here.
Top