Bug - Fixed lose track of zone-specific familiar weight modifiers

[Veracity]

A clannie sent me this: "the catfish folder isn't being accounted for when calculating familiar weight underwater"

That puzzled me, so I experimented.

The green sidepane says my familiar is 63 lbs.

> modtrace familiar weight

source			     Familiar Weight
belt of loathing	       +10.00=+10.00
folder (heavy metal)		+5.00=+15.00
cute bow from beyond the stars	+5.00=+20.00
amphibian sympathy		+5.00=+25.00
leash of linguini		+5.00=+30.00
happy salamander		+3.00=+33.00
empathy				+5.00=+38.00
billiards belligerence		+5.00=+43.00

I selected a location in The Sea. The green sidepane says my familiar is 78 lbs.

> modtrace familiar weight

source			     Familiar Weight
belt of loathing	       +10.00=+10.00
folder (heavy metal)		+5.00=+15.00
folder (catfish)	       +15.00=+30.00
cute bow from beyond the stars	+5.00=+35.00
amphibian sympathy		+5.00=+40.00
leash of linguini		+5.00=+45.00
happy salamander		+3.00=+48.00
empathy				+5.00=+53.00
billiards belligerence		+5.00=+58.00

I adventured in the Sea Location. The green sidepane went down to 63 lbs.

Turns out both api.php and charpane.php do not include the zone-specific modifier in what they display, no matter where you last adventured.

I adventured in The Sea again and refreshed both charpane.php and api.php while I was in the middle of the fight. No change. KoL told me that my familiar weighed 63 lbs.

- Perhaps KoL has a bug and won't display the correct familiar weight in this case, even if you are actively in the correct zone.
- Perhaps KoL has a bug and the catfish folder really does not give your familiar a +15 weight bonus.

I'll submit a bug report and wait for it to be ignored, as usual. In the mean time, I have the issue recorded here. I am not sure if there is anything we could or should do about it.

 

[Veracity]

KoL bug report submitted:

I have a 20 lb. familiar and familiar weight skills & equipment that add 43 lbs. to it.

Both charpane.php and api.php tell me that it weighs 63 lbs. Good.

I added an over-the-shoulder folder holder with a "catfish" folder in it, that gives "+15 to Familiar Weight (Underwater only)".

Both charpane.php and api.php say my familiar weighs 63 lbs. OK, I haven't been underwater yet...

I visit a location in The Sea.

Both charpane.php and api.php say my familiar weighs 63 lbs.

Is that right? I am in the middle of a fight. I AM "Underwater" right now.

So which bug is it?

- charpane.php and api.php don't include the catfish folder - even if you are in the middle of an Underwater fight.
- the catfish folder doesn't actually improve your familiar weight when you are Underwater.

 

[Veracity]

From JLE (#169283) [reply] [quoted]
Date: Monday, December 23, 2013, 05:38PM

I believe that the underwater thing is as follows:

Because the weight is not a general increase, but dependent on location, it doesn't get displayed in the left panel, or when you look at the terrarium: these interfaces are not tied to the "location" that you are in.

however, it acts as *effectively* that much heavier in the water. (I hope. I'll test it out sometime tomorrow on a devster where I can see the numbers.)

We'll see what he has to say tomorrow, but this may end up being a "Hidden Familiar Weight" modifier, not a "Familiar Weight" modifier - which is to say, we will correctly track the +Item Drop effects, for example, corresponding to the total weight, but we will not show it on our green sidepane - just as KoL doesn't.

 

[Veracity]

Haven't heard back, but it's clear that charpane.php and api.php will not be modified to show damiliar weight that is zone-specific - and since we have "Familiar Weight (hidden)" to deal with that already, I'll just mark the catfish folder as such.

Revision 13440