Bug - Fixed Loathing Legion abacus MP cost reduction is incorrect

[Captain Kirk]

If you equip the abacus, you'll notice skills like leash of linguini get cost reduced from 12 to 9 (which it shouldn't
because it's not an in-combat skill) and also the cost reduction of the abacus is 5, not 3. I don't know if
the in-combat reduction is incorrect or not.

 

[slyz]

This should have been fixed in r8877. In modifiers.txt, the Loathing Legion abacus entry looks like this:

Loathing Legion abacus	Combat Mana Cost: -5, Softcore Only

Should it be:

Loathing Legion abacus	Mana Cost (combat): -5, Softcore Only

?

EDIT: the pattern for "Combat Mana Cost" also had to be modified in Modifiers.java. Here is a patch to fix the issue.

 

[Veracity]

Yes. "Combat Mana Cost" is the name of the modifier for the purpose of ASH's get_numeric_modifier, but "Mana Cost (combat)" should be what we use in modifiers.txt. Try revision 9087