Github Bot
Poster of Commits
Language Server - parsetree abstracts (#30)
( from https://kolmafia.us/threads/ash-language-server-features.26098/post-163993 )
A few appetizers while we wait for the rest:
* The classes CompositeType, CompositeValue and AggregateValue should be made abstract.
* The method CompositeType.getDataType( Object ) can be made abstract.
Rather than having Type.toString() and RecordType.toString() both be return this.name, just make Symbol.toString() { return this.name; } (this also incidentally adds the method to Variable and Function, which helps in the debugger)
View the full commit on Github
( from https://kolmafia.us/threads/ash-language-server-features.26098/post-163993 )
A few appetizers while we wait for the rest:
* The classes CompositeType, CompositeValue and AggregateValue should be made abstract.
* The method CompositeType.getDataType( Object ) can be made abstract.
Rather than having Type.toString() and RecordType.toString() both be return this.name, just make Symbol.toString() { return this.name; } (this also incidentally adds the method to Variable and Function, which helps in the debugger)
View the full commit on Github