Feature - Implemented KoL Update: Effects get messed up if you have 0 turns of an effect in your mood

Bale

Minion
If you have an effect in your mood, but don't actually have the effect, mafia will add that effect to your charpane so that you can click the red arrow and get some of it. Unfortunately that is being displayed in the old 2 column format, instead of the new 3 column format. It looks like this:

DaXCFMk.png


Probably just need to add <td></td> at the front of those effects. Here's the html:

HTML:
b><font size=2>Effects:</font></b><br><font size=2 color=black>[<a title="I'm feeling moody" href="/KoLmafia/sideCommand?cmd=mood+execute&pwd=3ba292037b4444ec1c667a361625e2b2" style="color:black">mood default, noncom</a>]</font><br><table><tr><td><img src="http://images.kingdomofloathing.com/itemimages/happy.gif" class=hand alt="Fresh Scent" title="Fresh Scent" onClick='eff("a12c86c626c44ecd48540d1e55bf1204");'></td><td><font size=2>Fresh Scent (0)</font> <a href="/KoLmafia/sideCommand?cmd=ashq+if%28can_interact%28%29%29+cli_execute%28%22use+either+1+chunk+of+rock+salt%2C+1+deodorant%22%29%3B&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Fresh Scent"><img src="/images/redup.gif" border=0></a></td></tr><tr><td><img src="http://images.kingdomofloathing.com/itemimages/footprints.gif" class=hand alt="Smooth Movements" title="Smooth Movements" onClick='eff("173a9c4b4bbef78643fe4ec1a93b1cfc");'></td><td><font size=2>Smooth Movements (0)</font> <a href="/KoLmafia/sideCommand?cmd=cast+1+Smooth+Movement&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Smooth Movements"><img src="/images/redup.gif" border=0></a></td></tr><tr><td></td><td><img src="http://images.kingdomofloathing.com/itemimages/rparen.gif"></td><td valign=center><font size=2>Semirare window end (<a href="/KoLmafia/sideCommand?cmd=counters+deletehash+14283561&pwd=3ba292037b4444ec1c667a361625e2b2">8</a>)</td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/sonata.gif" width=20 height=20  onClick='eff("b757f23feb7f08bd250f63586e03cf4a");' oncontextmenu='return shrug(162, "The Sonata of Sneakiness");'></td><td valign=center><font size=2>The Sonata of Sneakiness (<a href="/KoLmafia/sideCommand?cmd=uneffect+The+Sonata+of+Sneakiness&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the The Sonata of Sneakiness effect">25</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+The+Sonata+of+Sneakiness&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of The Sonata of Sneakiness"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/ocelot.gif" width=20 height=20  onClick='eff("5ac8444ac684a7f9113690c1f254c1e4");' oncontextmenu='return hardshrug(1193, "Singer's Faithful Ocelot");'></td><td valign=center><font size=2>Singer's Faithful Ocelot (<a href="/KoLmafia/sideCommand?cmd=uneffect+Singer%27s+Faithful+Ocelot&pwd=3ba292037b4444ec1c667a361625e2b2" title="Use a remedy to remove the Singer's Faithful Ocelot effect">369</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Singer%27s+Faithful+Ocelot&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Singer's Faithful Ocelot"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/string.gif" width=20 height=20  onClick='eff("2d6d3ab04b40e1523aa9c716a04b3aab");' oncontextmenu='return hardshrug(16, "Leash of Linguini");'></td><td valign=center><font size=2>Leash of Linguini (<a href="/KoLmafia/sideCommand?cmd=uneffect+Leash+of+Linguini&pwd=3ba292037b4444ec1c667a361625e2b2" title="Use a remedy to remove the Leash of Linguini effect">379</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Leash+of+Linguini&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Leash of Linguini"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/fatleons.gif" width=20 height=20  onClick='eff("63e73adb3ecfb0cbf544db435eeeaf00");' oncontextmenu='return shrug(67, "Fat Leon's Phat Loot Lyric");'></td><td valign=center><font size=2>Fat Leon's Phat Loot Lyric (<a href="/KoLmafia/sideCommand?cmd=uneffect+Fat+Leon%27s+Phat+Loot+Lyric&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Fat Leon's Phat Loot Lyric effect">589</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Fat+Leon%27s+Phat+Loot+Lyric&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Fat Leon's Phat Loot Lyric"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/superiority.gif" width=20 height=20  onClick='eff("2e5a803cf1be5b3d2aaa897e60f29138");' oncontextmenu='return shrug(70, "Stevedave's Shanty of Superiority");'></td><td valign=center><font size=2>Stevedave's Shanty of Superiority (<a href="/KoLmafia/sideCommand?cmd=uneffect+Stevedave%27s+Shanty+of+Superiority&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Stevedave's Shanty of Superiority effect">589</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Stevedave%27s+Shanty+of+Superiority&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Stevedave's Shanty of Superiority"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/elesphere.gif" width=20 height=20  onClick='eff("e3d1d1099648703e192a55a9aea17a1e");' oncontextmenu='return shrug(53, "Elemental Saucesphere");'></td><td valign=center><font size=2>Elemental Saucesphere (<a href="/KoLmafia/sideCommand?cmd=uneffect+Elemental+Saucesphere&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Elemental Saucesphere effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Elemental+Saucesphere&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Elemental Saucesphere"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/blackshell.gif" width=20 height=20  onClick='eff("4e66acac6b908fb6f70b49092dcff375");' oncontextmenu='return shrug(52, "Astral Shell");'></td><td valign=center><font size=2>Astral Shell (<a href="/KoLmafia/sideCommand?cmd=uneffect+Astral+Shell&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Astral Shell effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Astral+Shell&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Astral Shell"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/ghosturtle.gif" width=20 height=20  onClick='eff("9d5cb67507556bb105664b1dc9e8bf9a");' oncontextmenu='return shrug(18, "Ghostly Shell");'></td><td valign=center><font size=2>Ghostly Shell (<a href="/KoLmafia/sideCommand?cmd=uneffect+Ghostly+Shell&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Ghostly Shell effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Ghostly+Shell&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Ghostly Shell"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/scharm.gif" width=20 height=20  onClick='eff("6c7b4a5a3c6807d21493f1253bf8dfd9");' oncontextmenu='return shrug(19, "Reptilian Fortitude");'></td><td valign=center><font size=2>Reptilian Fortitude (<a href="/KoLmafia/sideCommand?cmd=uneffect+Reptilian+Fortitude&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Reptilian Fortitude effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Reptilian+Fortitude&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Reptilian Fortitude"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/empathy.gif" width=20 height=20  onClick='eff("ac32e95f470a7e0999863fa0db58d808");' oncontextmenu='return shrug(50, "Empathy");'></td><td valign=center><font size=2>Empathy (<a href="/KoLmafia/sideCommand?cmd=uneffect+Empathy&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Empathy effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Empathy+of+the+Newt&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Empathy"><img src="/images/up.gif" border=0></a></font><br></td></tr><tr><td></td><td valign='middle' align=right><img src="http://images.kingdomofloathing.com/itemimages/snapper.gif" width=20 height=20  onClick='eff("c05dc4b01f6f2826be599f07620979f7");' oncontextmenu='return shrug(51, "Tenacity of the Snapper");'></td><td valign=center><font size=2>Tenacity of the Snapper (<a href="/KoLmafia/sideCommand?cmd=uneffect+Tenacity+of+the+Snapper&pwd=3ba292037b4444ec1c667a361625e2b2" title="Shrug off the Tenacity of the Snapper effect">594</a>) <a href="/KoLmafia/sideCommand?cmd=cast+1+Tenacity+of+the+Snapper&pwd=3ba292037b4444ec1c667a361625e2b2" title="Increase rounds of Tenacity of the Snapper"><img src="/images/up.gif" border=0></a></font><br></td></tr></table><center><b><font size=2>Intrinsics:</font></b></center><center><table><tr><td><img height=20 width=20 src="http://images.kingdomofloathing.com/itemimages/snowflake.gif" onClick='eff("518f53443c261c2b61ea11fe8716a715");'></td><td valign=center><font size=2>Spirit of Peppermint (∞)</font><br></td></tr></table>
 
The other special Mafia effects like "Semirare window end" above, fortune cookie, etc. have the same issue. It's because of those new effect-boost arrows on the left, which are pretty much exactly like the Mafia version...which is sort of redundant now, not that it matters much.
 
The other special Mafia effects like "Semirare window end" above, fortune cookie, etc. have the same issue. It's because of those new effect-boost arrows on the left, which are pretty much exactly like the Mafia version...which is sort of redundant now, not that it matters much.

Counters were fixed in r12315 and I haven't seen the problem since then. That was about 6 hours ago. Have you updated since then?


exactly like the Mafia version...which is sort of redundant now, not that it matters much.

They are not completely redundant since mafia provides up-arrows for effects given by items even if you don't currently possess the item.
 
Last edited:
12316 fixes the alignment.

They are not completely redundant since mafia provides up-arrows for effects given by items even if you don't currently possess the item.
There might be confusion coming from G-D about the fact that KoL only adds arrows for effects that you have extended since the change was rolled out. I'm guessing KoL remembers how you got the effect and maintains an arrow for that action. KoL also has the option to display the last X effects that ran out (not stored across sessions), which can serve a similar purpose to moods.
 
Back
Top