Feature - Implemented Increase visibility of coverage deltas on GitHub

[fronobulax]

You can click on a merged PR and get coverage data and changes associated with the merged PR. See below. For interpretation see https://docs.codecov.com/docs/codecov-delta.




I would love to see these numbers when reviewing a PR. I think this is a two step process. One is running the coverage generation tool as part of the PR workflow. The other part is making the values more visible. Maybe it is quickly available when viewing the results of the "checks"?

 

[Veracity]

You can "click on" it where? I just went to github in my browser (as I always do) and found that PR and poked around a lot. I never saw anything that looks like what you are showing. Like that bar with Diff/Files/Build/Graphs.

 

[Rinn]

I had tried to add a gihub action that posted a comment with the code coverage \ specific unit testing results in a PR but it was a giant pain because the normal action workflow for PRs isn't allowed to comment because it's a security concern, and using the correct workflow was more arduous than I was willing to commit to at the time.

 

[fronobulax]

You can "click on" it where? I just went to github in my browser (as I always do) and found that PR and poked around a lot. I never saw anything that looks like what you are showing. Like that bar with Diff/Files/Build/Graphs.

The report is not currently available for a PR under review, but not merged.

The quickest way to get to the report for main is to go to the bottom of this page. https://github.com/kolmafia/kolmafia

There is a "badge" that says "Coverage" followed by a percent. You can click on the badge and it will bring up coverage data.

Code coverage done right.

Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA.

codecov.io

You can scroll down and on the right side is a list of Recent Commits. You can press the Browse Report for the commit of interest and that gets you the page I took the screenshot from.

Code coverage done right.

Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA.

codecov.io

To be less verbose, the FR is for a similar report for a PR than has not been approved or merged.

 

[fronobulax]

I had tried to add a gihub action that posted a comment with the code coverage \ specific unit testing results in a PR but it was a giant pain because the normal action workflow for PRs isn't allowed to comment because it's a security concern, and using the correct workflow was more arduous than I was willing to commit to at the time.

I have a vague recollection of that. Is it possible to emit something to the log file that is generated. I do dig into workflow logs occasionally and this is of enough interest that I'll accept the extra clicks to get it.

 

[fronobulax]

Tangentially, I Am Amused.

100% of the changes in DebugDatabase were tested and almost 97% of all the changes were tested.

 

[heeheehee]

97% refers to the commit as a whole, while 100% is file-level (incremental) coverage. CheckDataCommand.java did not have 100% incremental coverage.

 

[fronobulax]

97% refers to the commit as a whole, while 100% is file-level (incremental) coverage. CheckDataCommand.java did not have 100% incremental coverage.

??

If I had said "almost 97% of all the changes in this commit" would it have been clearer what I understood?

 

[gausie]

We now have a workflow that shows coverage per PR!