Bug Hermit treated as NPC store

[heeheehee]

Now that coinmasters are a thing, the Hermit should probably not obey autoSatisfyWithNPCs, but rather autoSatisfyWithCoinmasters.

See attached for patch.

 

[Catch-22]

I agree that it would seem more consistent for the hermit to be considered a coinmaster, but making only this change doesn't exactly make things more consistent. You'd need some associated coinmasters.txt data, you'd need to treat hermitage purchases as coinmaster requests, and because there's 3 valid tokens, you'd need special handling for that too.

Even after all that, it also becomes an issue of how many people are already accustomed to the hermitage being considered a normal NPC and might be upset by the change.

 

[heeheehee]

Well...

public class HermitRequest
        extends CoinMasterRequest

 

[Bale]

Catch-22, it is my understanding that the hermit is already treated as a coinmaster with the singular exception of this preference. That's why hee-3 listed it as a bug. It is in the coinmaster interface for a reason.

While it is true that the hermit is not listed in coinmasters.txt, neither is the Mr. Store. Both of which have a "visit" button and some special handling.

 

[Catch-22]

Catch-22, it is my understanding that the hermit is already treated as a coinmaster with the singular exception of this preference.

Ah right, well that'll teach me for not looking. Carry on, my wayward son.