Bug - Fixed get_workshed() no longer returning mayo clinic

[phreddrickk]

Seems to have started happening today. I checked both on login and after visiting my workshed in the relay browser. Presumably related to the fact that mayo clinic is shop.php. I can no longer check to see if mafia remembers when I actively use the mayo clinic (because I've already used the mayo clinic today), but it's not able to read it from campground.php?action=workshed

 

[Veracity]

OK. I can see the issue. For NPC shops, we are no longer parsing the response unless you are actually buying something.
I would not be surprised is that is the issue with the Fireworks Shop, too.
I'll fix that.

 

[Veracity]

I see that both fwshop and mayoclinic need to examine the responseText for simple visits.
I have an aftercore character with access to the Fireworks Shop, so I was able to write a test.
I have an open PR which fixes the issue.

NPC shops need to examine responseText on visits by Veracity0 · Pull Request #2713 · kolmafia/kolmafia

github.com

 

[phreddrickk]

This should contain html of the mayo clinic (I have since logged out so my pwdhash being visible should be fine)

 

[Veracity]

Thanks. I added a test using your html.
Ryo already merged my previous commit - which fixed both the FIreworks Shop and the Mayo Clinic - so I have a new PR with nothing but a test for the Mayo Clinic.

I may just merge that one myself.

 

[phreddrickk]

Between your test and me logging in just now I'm ready to go ahead and edit this post to FIXED! Thanks!