phreddrickk
Member
This feature request comes free with a PR!
I've been automating my ascensions and gash-hopping process lately, and I'd like to add support to Mafia for the tracking of permed skills. Mafia appears to already track some of this information in KoLConstants.permedSkills, so it feels like this isn't particularly invasive.
To this end, I've added separate tracking for which skills are hardcore-permed, and implemented a get_permed_skills ASH function, which returns a boolean[skill], whose values tell us whether a skill is hardcore permed. So an unpermed skill will not exist in the map, a softcore permed will exist with a value of false, and a hardcore skill will exist with a value of true. Because of the way we read this information, it currently seems to ignore most or all bookshelf skills--this feels like not a dealbreaker to me, because we currently don't flag those skills as permable, so this feels like consistent behavior.
I've been automating my ascensions and gash-hopping process lately, and I'd like to add support to Mafia for the tracking of permed skills. Mafia appears to already track some of this information in KoLConstants.permedSkills, so it feels like this isn't particularly invasive.
To this end, I've added separate tracking for which skills are hardcore-permed, and implemented a get_permed_skills ASH function, which returns a boolean[skill], whose values tell us whether a skill is hardcore permed. So an unpermed skill will not exist in the map, a softcore permed will exist with a value of false, and a hardcore skill will exist with a value of true. Because of the way we read this information, it currently seems to ignore most or all bookshelf skills--this feels like not a dealbreaker to me, because we currently don't flag those skills as permable, so this feels like consistent behavior.