Feature - Implemented Familiars, feast tracking, Warm Subject efficiency, and Hot tub restorative

Theraze

Theraze

Active member
With FightRequest normalized now, checked through my version to see what was left in the bug fixes and missing bits that are likely to be an easy approve/fail.

1) The hippo ballerina was missing in the CoT. Wiki says that it's a +20 meat drop. Added to modifiers data file.
2) Hot tub wasn't listed as a possible restorative. Using the _hottubsoaks variable, consider the hot tub as a possible restorative item if you need at least half your health. This adds to HPRestoreItemList.
3) Feasting isn't considered for modifiers. Since it adds 10 weight, I added a check for the boolean of feasted and did a +10 weight if so to the Modifiers file in both places where it's checked.
4) Warm Subject certificates had their own UseItemRequest though it uses exactly the same command as the other 15 items. Incorporated the certificates into the main switch-list in CleanupJunkRequest.

If any of these are on the "Bad!" list, please let me know and I'll try to avoid bringing them up again. Thanks! :)

Edit: Occurs to me that the wording is odd. I split the "familiars feast tracking" into "familiars, feast tracking" which is sort of correct, sort of not. Familiars applies both to the feast tracking, as well as the crown of thrones.
 

Attachments

Last edited:
Theraze said:
2) Hot tub wasn't listed as a possible restorative. Using the _hottubsoaks variable, consider the hot tub as a possible restorative item if you need at least half your health. This adds to HPRestoreItemList.
Click to expand...
Depending on the current situation, I may not want to use the hottub just for HP. For example, if you're a muscle class with lots of +ML at the appropriate level, you may want to save the hot tub for getting rid of nasty effects like cuntatitis. If there's a check box to control use of the hot tub along with the rest of the HP restorers, this would be fine, but if there's no way for me to control mafia's choice of hot tub uses other than to turn off all restoration, that seems undesirable. Not sure exactly how you've got this set up, though, but wanted to make sure this was brought to your attention.
Theraze said:
4) Warm Subject certificates had their own UseItemRequest though it uses exactly the same command as the other 15 items. Incorporated the certificates into the main switch-list in CleanupJunkRequest.
Click to expand...
It didn't have its own function to properly handle the fact that the first WS cert gives a shirt, while further ones give meat, did it? I doubt it, but thought it may be a good thing to keep in mind. I could very well be wrong. ;)
 
Regarding 2, it just lists it as an additional checkbox in the big wall of restoratives. If you want it to be an automatic addition to restorehp, it will be. If not, it isn't.

Regarding 4, it may have... at some point. But at this point, the function called is exactly the same, letter for letter...
 
Re 2: Awesome, just checking, just in case. ;)

Re 4: Yeah, it was all I could come up with... strikes me that there was probably a reason at some point... perhaps before the AJAX-ified multi-use there was actually a reason... :shrug:
 
I think you used to get multiple shirts if you multi-used them, don't quote me on that I'm not sure.
 
Maybe used to, but now it gets one the first time, then gets meat. At least, that's what happens when I do use * warm subject.
 
Theraze said:
3) Feasting isn't considered for modifiers. Since it adds 10 weight, I added a check for the boolean of feasted and did a +10 weight if so to the Modifiers file in both places where it's checked.
Click to expand...
If the modifier can check whether or not this is still available, why does it suggest pool and arena buffs after they've been used up? (as well as others, potentially)
Edit: Or is this strictly for the actual scoring of already active modifiers and not the maximizer?
 
Last edited:
You misunderstand what was meant by "isn't considered for modifiers". If you do a "modtrace familiar weight", it tells you everything which adds to your familiar weight, but didn't used to consider whether the familiar was extremely well fed. The patch made it consider that.

This has nothing to do with the modifier maximizer, which is what I assume you mean when you refer to "the modifier" suggesting pool and arena buffs.
 
You must log in or register to reply here.
Back
Top