Bug - Fixed "Documentation" frames don't load images

[Veracity]

If you go to the "Internal Database" on the Help menu (which I originally called the "Encyclopedia", but which hola renamed. Boo, hiss.) you can call up KoL's "description" for Items, Effects, Familiars, Skills, and Outfits. All of those include an image.

If you happen to have the image in your local image cache, it shows fine. For example, if you've seen it in the Relay Browser.

But, if you have not looked at the image, we don't seem to download it. Here is an example for a brand-new item whose description I have not looked at in the Relay Browser.



We manually download images for familiars so that we can put them into the green sidepane. Perhaps we need to do something of the sort for what we show in Documentation frames?

 

[Veracity]

Interesting. RequestFrame.showHTML has the following code:

		Matcher imageMatcher = RequestFrame.IMAGE_PATTERN.matcher( responseText );
		while ( imageMatcher.find() )
		{
			FileUtilities.downloadImage( imageMatcher.group() );
		}

Obviously, it's trying to load images. I'll have to look at that pattern.

 

[Bale]

If you go to the "Internal Database" on the Help menu (which I originally called the "Encyclopedia", but which hola renamed. Boo, hiss.)

I rather like Encyclopedia better. I know that I would have been using it a lot sooner in my life if it hadn't had such a boring name, but I suppose it would be rude to open a feature request to rename it.

 

[Veracity]

Sure enough. The item description has the following:

<img src="//images.kingdomofloathing.com/itemimages/polypants.gif" height=30 width=30 alt="polypants">

No http: in front.

Revision 15152 deals with this.

 

[Veracity]

I rather like Encyclopedia better. I know that I would have been using it a lot sooner in my life if it hadn't had such a boring name, but I suppose it would be rude to open a feature request to rename it.

I wouldn't find that rude.