Bug - Fixed DebugDatabase.checkModifiers confused by modifier with effect id

[Veracity]

- is out of range, returning 0

This from the following line in DebugModifiers.checkModifiers:

int descValue = StringUtilities.parseInt( value );

Where "value" is "Slicked-Back Do"

Which results from the following line in modifiers.txt:

Item	hair oil	Effect: "[1342]Slicked-Back Do", Effect Duration: 10

This happens because that method assumes that if a modifier value contains something in [], that is an expression.

Perhaps we should simply not make that assumption for the "Effect" modifier. Or, perhaps, only parse expressions for numeric modifiers, since we don't have non-numeric modifier expressions.

 

[Darzil]

The latter idea sounds a more general fix.

 

[Veracity]

Revision 15782 only evaluates expressions for numeric modifiers.

Now we have this:

# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[599]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[598]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[601]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[601]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[601]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[601]A Little Bit Evil" should be Effect: "A Little Bit Evil"
# *** modifier Effect: "[800]Chocolate Reign" should be Effect: "Chocolate Reign"
# *** modifier Effect: "[1342]Slicked-Back Do" should be Effect: "Slicked-Back Do"
# *** modifier Effect: "[1060]Chocolate Reign" should be Effect: "Chocolate Reign"

Fixing that WOULD require special coding for the "Effect" modifier.

 

[Veracity]

Bumping to remind myself to deal with the erroneous errors listed above.

 

[Veracity]

Revision 15853 eliminates the erroneous error messages.