Bug - Fixed Daily settings sometimes left blank instead of set to defaults.txt value

P

PeKaJe

Member
The last couple of days, I've noticed that some of my custom daily deeds that reference daily settings will show the setting name instead of their value. For example, _pantsgivingBanish would show instead of 0 at the start of the day. In the CLI I typed "get _pantsgivingBanish" and got nothing returned, where I should have gotten 0. I checked the _prefs.txt file and _pantsgivingBanish was in there, but with no = and nothing after. I tried reproducing this with backed up settings in various builds of mafia, to narrow down when this bug started happening, but found that sometimes the settings did in fact get reset correctly with builds that previously were buggy (it was late, but I'm pretty sure I took out a fresh backup of my settings for each attempt). My best bet would be that it was the change in r15067 that introduced this, since there are changes to Preferences.java here. Reverting that in a custom build appears to stop the bug happening, though it's hard to be certain when there's maybe some non-deterministic behaviour. I queried other people in /clan, and some with recent builds saw similar problems, while others did not.
 
I also noticed this, starting very recently. I was worried I had done something weird with being logged on through rollover (even though that didn't cause issues before), so I hadn't mentioned it.
 
I noticed that today, my steam cheerleader's steam was not reset to 200 at rollover. (I started with 0 steam.) I was waiting to see if it happened tomorrow also before reporting.
 
When I moved some settings from GLOBAL to user, I also changed Preferences.java to use "for" iterators. I bet I broke this. I'll look at it.
 
You must log in or register to reply here.
Back
Top