Bug - Fixed conditional use of gaudy key

[ckb]

Currently, mafia tries to use the gaudy key as soon as it is obtained. This is usually not a problem.
However, with Rain Man, you can fight a gaudy pirate and obtain a gaudy key at any time.

From my recent experience, the gaudy key will only be successfully used (and result in a snakehead charm) IF you have access to Belowdecks. Usually at this point it involves wearing the pirate fledges AND having opened/unlocked Belowdecks.

Mafia will currently try to use all gaudy keys immediately and will assume they are used successfully, even if they are not successful. This messes up the inventory and requires a manual refresh to get them back into the Mafia inventory.

 

[lostcalpolydude]

Currently, mafia tries to use the gaudy key as soon as it is obtained.

I think that will only happen if you have the talisman as a goal, or possibly snakehead charms as a goal, because I haven't seen that when using Rain Man on a gaudy pirate, or even when adventuring there normally (since I don't use goals).

I suspect that you have a script trying to automatically use them.

Mafia should probably recognize when you can't use them, and recognize failure if you try anyway (through the relay browser).

 

[ckb]

ok, yes indeed - I do have a script that is trying to automatically use them. Silly me.
However, Mafia still fails to detect an unsuccessful gaudy key usage (where the key is not consumed).

So it is a bug, just not the exact bug I mentioned in post 1.

 

[Darzil]

Edit - I think we should test for success - "In typical video game fashion, the key vanishes after having been used once"

 

[lostcalpolydude]

14911