Bug Build process no longer cleans out old jar files

[fronobulax]

Before the update to Gradle (step one) and the replacement of the build file (step 2) "gradlew shadowjar" would delete all versions of the kolmafia jar file except the one just created.

After I updated to step one and built I had two jar files, one of which I manually deleted. I upgraded to step two and had two jar files. I switched to build from main and now have three files - the one I built with step 1 only yesterday, and the ones I built after step 2 today.

I consider the change of behavior a bug since I deliberately do not want or keep multiple versions locally

 

[Veracity]

Related: gradlew clean no longer deletes the file in dist.

 

[heeheehee]

https://github.com/kolmafia/kolmafia/pull/3032 does the trick for me.

 

[heeheehee]

I had merged the other PR, and then noticed that it generated build failures on macOS. I sent https://github.com/kolmafia/kolmafia/pull/3034 to revert back to the broken state, but I'd also approve an appropriate fix-forward.

 

[Ryo_Sangnoir]

I've filed https://github.com/kolmafia/kolmafia/pull/3035

The error occurs when the directory does not exist. I had assumed that `onlyIf dist.exists()` would mean the interior of delete wouldn't matter; it's clearly running it at runtime because you don't get type errors when the directory does exist, even though listFiles() can return null.

How weird.