Bug - Fixed buffed_hit_stat() is wrong (sometimes)

[ckb]

> ash buffed_hit_stat()

Returned: 2147483647

> ash my_buffedstat($stat[Muscle])

Returned: 479

@gausie
This error seems to have been introduced in r26200: https://kolmafia.us/threads/r26200-mods-doubling-selves-by-gausie-in.27238/

confirmed: buffed_hit_stat() reports correctly in r26199 and not in r26200

 

[gausie]

Sorry about this. I'll see if I can fix it today.

 

[gausie]

Are you sure you're not a muscle class with an "Attacks Cant Miss" modifier?

 

[ckb]

Mostly sure - I think I logged out of r26200 and back in on r26199 and the problem went away.
I'll check again...

 

[ckb]

Are you sure you're not a muscle class with an "Attacks Cant Miss" modifier?

ok, you are right - I guess I did not entirely understand this feature of buffed_hit_stat()... and now I know I should not use it to calculate weapon damage. I guess this is a feature and not a bug.
Likely the 'Attacks Cant Miss' buff wore out between my adventure testing, leading to the conclusion of the r26200 problem (and the fact that r26200 dealt with extra doubling of numbers).
Thanks for the explanation.

 

[ckb]

One more related bug. buffed_hit_stat() seems to only return 2147483647 with 'Attacks Cant Miss' if the weapon is a melee weapon (or rather - if the current_hit_stat()==$stat[Muscle])

> equip garbage sticker

Wielding garbage sticker...
Equipment changed.

> ash buffed_hit_stat();

Returned: 2147483647

> equip bottle rocket crossbow

Wielding bottle-rocket crossbow...
Equipment changed.

> ash buffed_hit_stat();

Returned: 271

> equip cosplay saber

Wielding Fourth of May Cosplay Saber...
Equipment changed.

> ash buffed_hit_stat();

Returned: 400

 

[heeheehee]

That is what the code has done since it was initially implemented back in 2014.

This should be a simple + easy-to-test fix, and would be good practice if anyone wants to submit a PR.