Bug - Not A Bug Bricks not actually giftable

Razorsoup

Razorsoup

Member
Typing this in the gCLI
Code: 
ash print(is_giftable($item[brick]));
returns
Code: 
true
Returned: void

but you cannot actually send a brick as a gift. Should this be returning true?
 
brick

This is a brick, which has been expertly balanced for throwing. It even has a piece of string tied around it so you can attach a note. It's these little touches of quality that really make for an enjoyable vandalism experience.

Type: usable (self or others)
Cannot be traded or discarded
Gift Item
Click to expand...
We mark it as a "gift item" because that's how KoL has it tagged.

We also mark it as "none, curse" because you can use it on others, but you can't just "use" it; there is the associated message.

Considering that KoL marks it as a "gift", I find it difficult to see why KoLmafia calling a "gift" is a bug. Perhaps it could use extra code to handle it as intended, but, since I have absolutely no interest in this item, I have no opinion on what that would be.
 
I'd call it a KoL bug. Report it to KoL. Let them fix it by removing "gift item" from the description.
 
Veracity said:
We mark it as a "gift item" because that's how KoL has it tagged.
...
Considering that KoL marks it as a "gift", I find it difficult to see why KoLmafia calling a "gift" is a bug.
Click to expand...

I think I understand where you are coming from. But on the other hand, non-gift items return true for is_giftable() because they can be gifted so why do we need to have $item[brick] return true when it can't be gifted? It is my understanding that that function reflects what can be done with the item in question. I think $item[brick].gift should reflect KoL's definition of whether or not it's a gift item but is_giftable($item[brick]) should reflect what can be done with the item.
 
Last edited:
Razorsoup said:
I think $item[brick].gift should reflect KoL's definition of whether or not it's a gift item but is_giftable($item[brick]) should reflect what can be done with the item.
Click to expand...

I'm not sure anyone else agrees with you. It is KoL's problem and KoL should fix it. Fixing KoL bugs in KoLmafia often leads to other problems.
 
You must log in or register to reply here.
Back
Top