Bug - Fixed arena/tcb/familiar jacks item result mapping

[phreddrickk]

Hi,

Right now, if I call the familiar_equipment function on someone like the cornbeefadon, I get $item[none] as my result. I assume this is deliberate, because the amulet coin that drops from the cornbeefadon isn't the cornbeefadon's unique familiar equip in the way that, say, the jubjub birds are for the frumious bandersnatch:

> js familiarEquipment(Familiar.get("cornbeefadon"))

Returned: none
id => -1
name =>
plural =>
[snipped other proxy records for space]

But, it's useful at times to know that if I have my cornbeefadon out and I use familiar jacks, or if I burn turns in the cake-shaped arena with my cornbeefadon, or I use the toy cupid bow on my cornbeefadon, I'm not going to end up with a lead necklace/heart, I'm going to end up with an amulet coin. I'd propose either amending the behavior of the familiar_equipment function or adding a new one--arena_prize--to represent non-specific familiar equipments associated with a particular familiar.

 

[gausie]

I think this is a straightforward mistake and we should indeed define familiars' equips as the items they get from the cake-shaped arena

 

[Veracity]

Including those who get a lead necklace? Why not, I guess.

 

[phreddrickk]

I'm not at my computer but I'm curious how bander--who gets one of three items, all of which effortlessly fold into eachother--currently works and how it should work.

 

[gausie]

To part the curtain a little bit, every familiar has an arenaprize field. Familiars that get a lead necklace have null there, and arena.php deals with that by giving a lead necklace. Tiny Cupid bow deals with it by giving a heart necklace.

I'd have to check how bander works but I would guess it either has null or whatever the developer felt like putting in there at the time. In either case it's probably just special cased in arena.php. TCB can probably tell us how bandersnatch is implemented as I know it has no special casing for any familiars

For this reason, I think lead necklace droppers should remain $item[none]

 

[Veracity]

Reasonable.

 

[phreddrickk]

Having checked all of these familiars:

> js Familiar.all().filter((f) => familiarEquipment(f) === Item.none && haveFamiliar(f))

Returned: aggregate familiar [23]
0 => Comma Chameleon
1 => Ragamuffin Imp
2 => Bulky Buddy Box
3 => Disembodied Hand
4 => Holiday Log
5 => Fancypants Scarecrow
6 => Reagnimated Gnome
7 => Unspeakachu
8 => Stooper
9 => Disgeist
10 => Cornbeefadon
11 => Mu
12 => God Lobster
13 => Pet Coral
14 => Left-Hand Man
15 => Ghost of Crimbo Carols
16 => Ghost of Crimbo Cheer
17 => Ghost of Crimbo Commerce
18 => Synthetic Rock
19 => Pixel Rock
20 => Flaming Leafcutter Ant
21 => Pet Anchor
22 => Golden Pet Rock

I can confirm that the only listed ones that don't give lead a lead necklace from familiar jacks is precisely the pokefam from that list.

The familiars I didn't check that currently are set to $item[none] are:
- El Vibrato Megadrone
- Mad Hatrack
- Black Cat
- April Fools familiars (e.g., money making goblin)
- Reconstituted Crow
- Pokefam available only in pokefam

Which is to say that I think this would be precisely a change to unspeakachu, stooper, disgeist, corbeefadon, and mu, but it'd be neat if someone could double check or otherwise confirm the others.

 

[gausie]

Fixed