Universal Recovery

I am thinking of:

1) Hosting the non-Bale changes to UR on SourceForge.
2) Granting commit access to anyone I know from Kolmafia.us who asks.
3) Modifying the Script Repository so the difference between the Old and the New is obvious.
4) Encouraging interested users to uninstall the Old and install the New.
5) Creating a new UR thread.

I can only see two issues. First it does appear that I am purloining Bale's work. I am OK with that since he has not responded to several attempts by me to contact him and if he asserts a claim I will honor it. Second, if someone has both versions installed via SVN it is not predictable which one will actually be installed, i.e. the version in /relay. But I think the solution is obvious - uninstall one.

Comments?

I probably do this on July 9 if no one objects.

Thanks.

For what it's worth I'm in favor of your plan.

Im in favor as well

fronobulax said:

Second, if someone has both versions installed via SVN it is not predictable which one will actually be installed, i.e. the version in /relay. But I think the solution is obvious - uninstall one.

Comments?

Click to expand...

The conflict between old and new version can be resolved by changing the name.
In documentation refer to it as universal recovery 2 or UR2. the ash script filename can be urecover.ash

taltamir said:

The conflict between old and new version can be resolved by changing the name.
In documentation refer to it as universal recovery 2 or UR2. the ash script filename can be urecover.ash

Click to expand...

I thought about that but decided I would rather uninstall the old Universal_recovery.ash once and install the new one than to have to change the name for multiple characters and in scripts that reference it. IMO YMMV

Thoughts about updating the original thread instead of creating a new one, as was the case with the community taking over support for Chit?

Too bad Mafia doesn't expose `svn relocate`.

The only reason for a new thread would be so that anyone who looked for help with the unsupported version could look for it "elsewhere". But maybe, given that I don't want to rename the file, perhaps one thread is the way to go.

Tangentially, it seems that Bale was maintaining svnrepo.json on github. I'm thinking it needs to be moved to SourceForge.

fronobulax said:

perhaps one thread is the way to go.

Click to expand...

I think so too. Another reason being that people who search for a recovery script will probably find the current, well-linked-to thread first.

Deed is done.

Moved svnrepo.json from GitHub to SourceForge.
Created new repository with UR code.
(Hopefully) gave zarqon complete access to new repository.
Edited svnrepo.json to make Old version OBE and point to new version.
Committed zarqon's changes.

https://svn.code.sf.net/p/kolmafiascripts/mafiarecovery/code/scripts

Will edit the UR thread momentarily.

Seems like sometimes it fails to notice that beaten up was removed
That red error message is incorrect, I did recover from being beaten up.

in kingdom of explothing doc galactic is unavailable. So if you run out of other restorers and it tries to resort to buying from galactic it gives the following infinite loop

taltamir said:

in kingdom of explothing doc galactic is unavailable. So if you run out of other restorers and it tries to resort to buying from galactic it gives the following infinite loop

Code:

Desired purchase quantity not reached (wanted 1, got 0)
(usable     quantity of Doc Galaktik's Homeopathic Elixir is limited to 0 by needed     restoration)
Desired purchase quantity not reached (wanted 1, got 0)
(usable     quantity of Doc Galaktik's Homeopathic Elixir is limited to 0 by needed     restoration)
Desired purchase quantity not reached (wanted 1, got 0)
(usable     quantity of Doc Galaktik's Homeopathic Elixir is limited to 0 by needed     restoration)
Desired purchase quantity not reached (wanted 1, got 0)
(usable     quantity of Doc Galaktik's Homeopathic Elixir is limited to 0 by needed     restoration)
Desired purchase quantity not reached (wanted 1, got 0)
(usable     quantity of Doc Galaktik's Homeopathic Elixir is limited to 0 by needed     restoration)

Click to expand...

Continued at https://kolmafia.us/showthread.php?1780-Universal-Recovery-Script/page241