I looked at this, and the huge bulk of it is changing text formatting. For example, in ValhallaDecorator.java:
Code:
507,509c281,282
< if ( InventoryManager.hasItem( ItemPool.CITADEL_SATCHEL ) )
< {
< buffer.append( "<nobr><a href=\"guild.php?place=paco\">complete white citadel quest by turning in White Citadel Satisfaction Satchel</a></nobr><br>" );
---
> if (InventoryManager.hasItem(ItemPool.CITADEL_SATCHEL)) {
> buffer.append("<nobr><a href=\"guild.php?place=paco\">complete white citadel quest by turning in White Citadel Satisfaction Satchel</a></nobr><br>");
It "cuddled" the curly brace. Here's another one from that same file:
Code:
551,555c323,326
< private static final void developerGift( final StringBuffer buffer, final int itemId, final String developer )
< {
< int giftCount = InventoryManager.getAccessibleCount( itemId );
< if ( giftCount <= 0 )
< {
---
> private static final void developerGift(final StringBuffer buffer,
> final int itemId, final String developer) {
> int giftCount = InventoryManager.getAccessibleCount(itemId);
> if (giftCount <= 0) {
It split the parameters into two lines and removed spaces next to parenthesis.
I very very very much do NOT like that. I could argue that imposing uniform formatting on the codebase with an automated tool is a good idea, but the vast majority of the code is in the "correct" format, according to our coding standards, and changing it to a different format is not acceptable.
I should probably write and check in the Coding Standards file that I've been talking about since July 1 of last year (the date I created an empty file to be filled in later).
