Bug - Fixed Test Failure

fronobulax

Developer
Staff member
ant test

fails in CustomScriptTest

Code:
    [junit] Running net.sourceforge.kolmafia.CustomScriptTest
    [junit] Testsuite: net.sourceforge.kolmafia.CustomScriptTest
    [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.126 sec
    [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.126 sec
    [junit]
    [junit] Testcase: testScripts(net.sourceforge.kolmafia.CustomScriptTest):   FAILED
    [junit] test_evilometer.txt output does not match:  expected:<...04 character string
    [junit] []Round 2: gargantulih...> but was:<...04 character string
    [junit] [MONSTERID not found
    [junit] ]Round 2: gargantulih...>
    [junit] junit.framework.AssertionFailedError: test_evilometer.txt output does not match:  expected:<...04 character string
    [junit] []Round 2: gargantulih...> but was:<...04 character string
    [junit] [MONSTERID not found
    [junit] ]Round 2: gargantulih...>
    [junit]     at net.sourceforge.kolmafia.CustomScriptTest.testScript(Unknown Source)
    [junit]     at net.sourceforge.kolmafia.CustomScriptTest.testScripts(Unknown Source)
    [junit]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [junit]     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    [junit]     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 

Veracity

Developer
Staff member
MONSTERID is now expected/required for parsing a fight text, so a saved fight text without such will no longer satisfy "test fight".
Revision 20311 fixes the text used in the test.
Revision 20312 fixes a few things in inebriety.txt and fullness.txt that broke a later test.

If you want to fix the items.txt test (by fixing the regexp), go for it!
 

fronobulax

Developer
Staff member
MONSTERID is now expected/required for parsing a fight text, so a saved fight text without such will no
If you want to fix the items.txt test (by fixing the regexp), go for it!

"want" != "being able to"

Haven't figured it out yet/
 
Top