Page 2 of 2 FirstFirst 1 2
Results 11 to 19 of 19

Thread: Excavator - gausie's spading script

  1. #11
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,849

    Default

    As I logged in today I saw some messages about spading data available and wouldn't I like to share it? I was surprised since excavator is installed and up to date. I typed "spade" into the gCLI and it appeared to send three hookah related reports.

    I see this as an interesting observation and not an issue to be fixed but I was surprised that things were queued and not fired off.

    My recollection is that the character did a Goo run, ascend into a softcore seal clubber and yesterday finished the run and went into aftercore. When the session started the character did not have the hookah but had and used it towards the end of the session. Maybe something that is done at login also needs to be done when the prism is broken?

    Unrelated probably but...

    I use other people's combat scripts, usually SimpleSmack. I get frustrated when SimpleSmack allows me to be beaten up or doesn't kill the monster within the round limit. I can at least detect this happened after the fact by putting an abort when beaten up into my mood. But then I have to manually examine and collect whatever data I need to figure out why SimpleSmack did what it was told as opposed to what I wanted :-)

    Since this appears to be a way to specify an event in mafia, gather data when it occurs and then share that data, is it possible for me to do that without having any access to GitHub at all? Can I write and deploy my own script and perhaps do something besides kmail the data? If so is there documentation or how to pointers you could point me to?

    Thanks.

  2. #12

    Default

    As I logged in today I saw some messages about spading data available and wouldn't I like to share it? I was surprised since excavator is installed and up to date. I typed "spade" into the gCLI and it appeared to send three hookah related reports.

    I see this as an interesting observation and not an issue to be fixed but I was surprised that things were queued and not fired off.

    My recollection is that the character did a Goo run, ascend into a softcore seal clubber and yesterday finished the run and went into aftercore. When the session started the character did not have the hookah but had and used it towards the end of the session. Maybe something that is done at login also needs to be done when the prism is broken?
    Originally Posted by fronobulax View Post
    I do the following check to see if your character is unable to send a kmail

    Code:
        if (
            // In a fight
            current_round() > 0 ||
            // In a choice
            handling_choice() ||
            // Was in a choice, gonna be in a fight
            fight_follows_choice() ||
            // Was in a fight, gonna be in a choice
            choice_follows_fight() ||
            // Was in a fight, gonna be in another fight
            in_multi_fight()
        )
    If not, I put the data into the spadingData pref. Whenever excavator next tries to send data and the above check passes, it sends all the old stuff too. So the idea is that it won't sit around there too long, but that you will get a native mafia reminder if you log in with some cached spading data.

    Unrelated probably but...

    I use other people's combat scripts, usually SimpleSmack. I get frustrated when SimpleSmack allows me to be beaten up or doesn't kill the monster within the round limit. I can at least detect this happened after the fact by putting an abort when beaten up into my mood. But then I have to manually examine and collect whatever data I need to figure out why SimpleSmack did what it was told as opposed to what I wanted :-)

    Since this appears to be a way to specify an event in mafia, gather data when it occurs and then share that data, is it possible for me to do that without having any access to GitHub at all? Can I write and deploy my own script and perhaps do something besides kmail the data? If so is there documentation or how to pointers you could point me to?
    Originally Posted by fronobulax View Post
    I put up some documentation on the wiki back in June. You could write your own spading script that does whatever you like, and get it to pass on to Excavator if you like. Something like

    Code:
    import <excavator.ash>;
    
    void main( string event, string meta, string page )
    {
      fronos_cool_code( event, meta, page );
      excavator@main( event, meta, page );
    }

  3. #13
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,849

    Default

    Thanks.

    I guess if the hookah data was discovered while in a fight and the script did not check for unsent reports to send until the next login that would explain it.

  4. #14
    Developer
    Join Date
    Apr 2006
    Posts
    972

    Default

    I added something like this to my logout script just to make sure any pending data was sent automatically
    Code:
    if (get_property("spadingData") != ""){
    	cli_execute("try; ash import excavator; flush_spading_data()");
    }

  5. #15
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,849

    Default

    Saw the send spade? text on login again. Same character. Not sure why but if it is repeatable I can start paying more attention :-)

    Got my own spade script to work - it just writes data to a local file - so thanks again.

  6. #16
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,849

    Default

    OK. It appears than neither of the two characters with hookah spading data are sending it. That would appear to be by design since Excavator doesn't send during a fight and shouldn't try. But the existing mechanic to send the data next chance Excavator gets does not seem to be working. If it were I don't think I would be getting nagged about sharing when logging in. Don't know whether that is a bug or just a side effect of the hookah being the only project those characters have data for.

    Now I have opted in to Excavator by installing it, allowing it to be SVN updated automatically and not picking and choosing which projects are allowed to collect data. So not only am I comfortable with having spading data sent automagically when ever it is available. I prefer that to having to watch messages scroll and type "spade" by or change my login or logout to do that.

    I'd be happy with any solution that gets the data sent and does not require me to type spade or change a script.

    If the nag comes from mafia I can understand wanting it, so maybe adding a data collection hook to logout that flushed everything? Adding the hook would be mafia but using it could be a registered script, right?

  7. #17

    Default

    I don't really want to hack into having a logout script when the user hasn't specified Excavator as their logout script - I think for now I will officially endorse Rinn's solution above, and maybe even go so far as to add it to the project's README

  8. #18
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,849

    Default

    I don't really want to hack into having a logout script when the user hasn't specified Excavator as their logout script - I think for now I will officially endorse Rinn's solution above, and maybe even go so far as to add it to the project's README
    Originally Posted by gausie View Post
    Given that the user experience for this feature was once advertised as "set a preference to excavator and your're done" there is an aspect of not keeping promises to endorsing Rinn's solution rather than making it not necessary.

    Given that it only seems to be the Hookah data that remains unsent for me, it feels like a design or implementation problem that could be addressed by someone with access to both mafia code and the script.

    Given that the current situation doesn't hurt me nearly as much as the spader I admit I am behaving somewhat like a troll or maybe even a sealion.

    So I will let this go and either have unsent spading data, implement a logout send, or provide a patch that fixes the flaw as I see it.

    :-)
    Well, thank you.
    Originally Posted by Veracity View Post

  9. #19

    Default

    Given that the user experience for this feature was once advertised as "set a preference to excavator and your're done" there is an aspect of not keeping promises to endorsing Rinn's solution rather than making it not necessary.

    Given that it only seems to be the Hookah data that remains unsent for me, it feels like a design or implementation problem that could be addressed by someone with access to both mafia code and the script.

    Given that the current situation doesn't hurt me nearly as much as the spader I admit I am behaving somewhat like a troll or maybe even a sealion.

    So I will let this go and either have unsent spading data, implement a logout send, or provide a patch that fixes the flaw as I see it.

    :-)
    Originally Posted by fronobulax View Post
    I'm glad we're on the same wavelength :P

    Perhaps the best patch for mafia here is to consolidate the dialogues produced by `spade` into a single confirmation. Or to add an "always send spading data" preference.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •