Results 1 to 8 of 8

Thread: Festival of Jarlsberg detection

  1. #1
    Senior Member
    Join Date
    Jan 2014
    Posts
    207

    Default Festival of Jarlsberg detection

    I believe this bug only applies on January 2nd. Mafia believes it is the Festival of Jarlsberg, but, today (2019-01-02), it is not.

    Code:
    > ash mana_cost_modifier()
    
    Returned: -3
    
    > ash holiday()
    
    Returned: Festival of Jarlsberg
    HolidayDatabase.java:
    Code:
    		if ( stringDate.endsWith( "0102" ) )
    		{
    			return "Festival of Jarlsberg";
    		}
    History of festival of jarlsberg

    Apparently there's an unknown mechanic for Festival of Jarlsberg? Here all the appearances that weren't on Jarlsuary 1:
    Code:
    Festival of Jarlsberg II: January 2, 2008 (Carlvember 5, Year 19)
    Festival of Jarlsberg VII: January 1, 2009 (Bor 2, Year 23)
    Festival of Jarlsberg IX: April 1, 2009 (Bill 4, Year 24)
    Festival of Jarlsberg XIII: January 2, 2010 (April 8, Year 27)
    Festival of Jarlsberg XVIII: January 2, 2011 (Frankruary 5, Year 31)
    Festival of Jarlsberg XXII: January 2, 2012 (Dougtember 2, Year 34)
    Festival of Jarlsberg XXVII: January 2, 2013 (Carlvember 8, Year 38)
    Festival of Jarlsberg XXXII: January 2, 2014 (Bor 5, Year 42)
    Festival of Jarlsberg XXXVII: January 2, 2015 (Martinus 2, Year 46)
    Festival of Jarlsberg XLII: January 2, 2016 (Frankuary 7, Year 50)
    Festival of Jarlsberg LIV: January 1, 2019 (Bor 6, Year 61)
    Sometimes it's January 2nd, other times, it's January 1st. Other times, it doesn't appear at the start of the year at all. (or it wasn't documented?)

  2. #2
    Developer
    Join Date
    Apr 2010
    Posts
    5,134

    Default

    So I guess Jan 1st was the intention, and Jan 2nd was a bug, and it is now fixed?

    Or something

  3. #3
    Senior Member
    Join Date
    Apr 2019
    Posts
    205

    Default Festival of Jarlsberg on the wrong date

    Don't know if it's only for this holiday, but Festival of Jarlsberg is internally set at today, the 2nd, though it happened yesterday, the 1st. Don't know if it's a 1-time error or if the date of that festival's cycle is actually wrong by 1 day.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,406

    Default

    According to The Wiki, The Festival of Jarlseberg is on Jarlsuary 1 (in the KoL Calendar) and also on certain days from the Real World™ Calendar. To wit:

    Code:
    Festival of Jarlsberg II: January 2, 2008 (Carlvember 5, Year 19)
    Festival of Jarlsberg VII: January 1, 2009 (Bor 2, Year 23)
    Festival of Jarlsberg IX: April 1, 2009 (Bill 4, Year 24)
    Festival of Jarlsberg XIII: January 2, 2010 (April 8, Year 27)
    Festival of Jarlsberg XVIII: January 2, 2011 (Frankruary 5, Year 31)
    Festival of Jarlsberg XXII: January 2, 2012 (Dougtember 2, Year 34)
    Festival of Jarlsberg XXVII: January 2, 2013 (Carlvember 8, Year 38)
    Festival of Jarlsberg XXXII: January 2, 2014 (Bor 5, Year 42)
    Festival of Jarlsberg XXXVII: January 2, 2015 (Martinus 2, Year 46)
    Festival of Jarlsberg XLII: January 2, 2016 (Frankuary 7, Year 50)
    Festival of Jarlsberg LIV: January 1, 2019 (Bor 6, Year 61)
    We have it coded to occur on January 2, since it has occurred 8 times on that date, as opposed to 2 times on January 1.

    So it appeared for the third time on January 1 in 2020.

    Maybe it's always going to be on January 1 from now on, since it appeared on that day in 2009, 2019 or 2020.
    Or maybe it's going to be on January 2 some of the time, since it appeared on that day in 2008, 2010, 2011, 2012, 2013, 2014, 2015, 2016.
    Or maybe it's not going to appear on a Real World™ Calendar day some of the time, just like in 2017 and 2018.

    Too bad we couldn't predict which behavior we'd see in 2020 before it appeared on January 1.

    Hard to see this as a "bug". Or even "new content" or a "feature".

  5. #5
    Senior Member
    Join Date
    Apr 2019
    Posts
    205

    Default

    there should be a manual way to tell mafia this information, though, as a lot of scripts including skill-casting will get errors because they'll try to cast skill you don't have the MP for

  6. #6
    Developer
    Join Date
    Apr 2006
    Posts
    962

    Default

    There's a cli command holiday that lets you force on holiday logic.

  7. #7
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,406

    Default

    Now that we've had this reported on Jan 2 for two years in a row, perhaps we should assume that it really will come on Jan 1 henceforth.

  8. #8
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,406

    Default

    Revision 19918
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •