Results 1 to 10 of 10

Thread: Changing smile buff reports 0 turns of effect gained

  1. #1

    Default Changing smile buff reports 0 turns of effect gained

    Code:
    > cast scowl
    
    Casting Scowl of the Auk 1 times...
    You acquire an effect: Scowl of the Auk (10)
    Scowl of the Auk was successfully cast.
    
    > cast leer
    
    Casting Disco Leer 1 times...
    You lose an effect: Scowl of the Auk (-10)
    You acquire an effect: Disco Leer (0)
    Disco Leer was successfully cast.
    
    > cast scowl
    
    Casting Scowl of the Auk 1 times...
    You lose an effect: Disco Leer (-10)
    You acquire an effect: Scowl of the Auk (0)
    Scowl of the Auk was successfully cast.
    Changing your smile buff reports that you gain 0 turns of the effect. It should be 10, I think.

    This also applies to swapping Musk / Smooth.
    Last edited by Ryo_Sangnoir; 09-01-2019 at 11:17 AM. Reason: musk / smooth

  2. #2

    Default

    Looking through my logs, I see a few other cases reporting 0 turns of an effect gained:

    Casting Incredible Self-Esteem and gaining Become Intensely Interested (others seem fine):
    Code:
    cast 1 Incredible Self-Esteem
    You acquire an effect: Become Intensely interested (0)
    Acquiring effects from the PYEC or License to Chill (bag of Tricks and Temple buff both look fine)... or it might be the Sacremental buff.
    Code:
    use 1 Platinum Yendorian Express Card
    You gain 2,842 Mana Points
    You acquire an effect: Ode to Booze (5)
    You acquire an effect: Pajama Party (5)
    You acquire an effect: Green Peace (5)
    You acquire an effect: Sacré Mental (0)
    You acquire an effect: familiar.enq (0)
    You acquire an effect: On Pins and Needles (0)
    You acquire an effect: Blood Bond (0)
    You acquire an effect: Disco Leer (0)
    You acquire an effect: Empathy (0)
    You acquire an effect: Fat Leon's Phat Loot Lyric (0)
    You acquire an effect: Leash of Linguini (0)
    You acquire an effect: Paul's Passionate Pop Song (0)
    You acquire an effect: Polka of Plenty (0)
    You acquire an effect: Singer's Faithful Ocelot (0)
    You acquire an effect: How to Scam Tourists (0)
    You acquire an effect: Bad Haircut (0)
    You acquire an effect: Puzzle Champ (0)
    You acquire an effect: Musk of the Moose (0)
    You acquire an effect: Warlock, Warstock, and Warbarrel (0)
    You acquire an effect: Got Milk (0)
    You acquire an effect: Do I Know You From Somewhere? (0)
    You acquire an effect: The Dinsey Way (0)
    You acquire an effect: Kicked in the Sinuses (0)
    You acquire an effect: Synthesis: Greed (0)
    You acquire an effect: Here's Some More Mud in Your Eye (0)
    You acquire an effect: meat.enh (0)
    You acquire an effect: Down the Rabbit Hole (0)
    You acquire an effect: Dances with Tweedles (0)
    You acquire an effect: Preternatural Greed (0)
    You acquire an effect: Billiards Belligerence (0)
    You acquire an effect: Clyde's Blessing (0)
    You acquire an effect: Always be Collecting (0)
    You acquire an effect: A View to Some Meat (0)
    You acquire an effect: Bastille Braggadocio (0)
    You acquire an effect: Meet the Meat (0)
    You acquire an effect: Uncucumbered (0)
    
    use 1 License to Chill
    You acquire an item: Afternoon Delight
    You gain 13 hit points
    You gain 1 Mana Point
    You acquire an effect: Ode to Booze (1)
    You acquire an effect: Sacré Mental (0)
    You acquire an effect: familiar.enq (0)
    You acquire an effect: On Pins and Needles (0)
    You acquire an effect: Blood Bond (0)
    You acquire an effect: Disco Leer (0)
    You acquire an effect: Fat Leon's Phat Loot Lyric (0)
    You acquire an effect: Leash of Linguini (0)
    You acquire an effect: Paul's Passionate Pop Song (0)
    You acquire an effect: Polka of Plenty (0)
    You acquire an effect: Singer's Faithful Ocelot (0)
    You acquire an effect: Bad Haircut (0)
    You acquire an effect: Puzzle Champ (0)
    You acquire an effect: Musk of the Moose (0)
    You acquire an effect: Warlock, Warstock, and Warbarrel (0)
    You acquire an effect: Do I Know You From Somewhere? (0)
    You acquire an effect: Kicked in the Sinuses (0)
    You acquire an effect: Here's Some More Mud in Your Eye (0)
    You acquire an effect: Dances with Tweedles (0)
    You acquire an effect: Preternatural Greed (0)
    You acquire an effect: Billiards Belligerence (0)
    You acquire an effect: Always be Collecting (0)
    You acquire an effect: Bastille Braggadocio (0)
    You acquire an effect: Meet the Meat (0)
    You gain 5 Adventures
    You gain 666 Magicalness
    You gain a Mysticality point!

  3. #3
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,119

    Default

    Revision 19526 correctly parses the "You lose an effect" message, which unlike "You lose some of an effect" or "You gain an effect", does not include a duration.

    If you can get a log for "cast 1 Incredible Self-Esteem", I will look at that.

    Regarding using items that extend effects, it is suspicious that everything is fine until we get to the effect with the diacritical mark, but I don't see anything in the pattern we are matching that wouldn't accept that. So, if you can get me a DEBUG log for that case, too, I'd appreciate it.

  4. #4
    Senior Member
    Join Date
    Aug 2015
    Posts
    264

    Default

    If you can get a log for "cast 1 Incredible Self-Esteem", I will look at that.
    Originally Posted by Veracity View Post
    From a quick check of some recent logs, it looks like it only shows (0) when it gives you an effect rather than when it extends an existing effect. I'll see if I can get a log for you tomorrow for both this and the License to Chill.

  5. #5
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,119

    Default

    Revision 19527 addresses the Sacré Mental issue.

    The actual effect name (as seen in the effect description) is Sacré Mental
    When KoL reports that you gain turns of it, it calls it Sacré Mental

    So now we try to compare on names as given, and if that fails, on entity encoded names.

  6. #6

    Default

    Today I got a debug log for Think Win-Lose, and all was fine. The two effects with the issue are "Become Intensely interested" and "Become Superficially interested". I'll keep trying until I get one of those.

  7. #7

    Default

    I got it from the affirmation itself, as well. The effect name begins with a space. I expect it's the same for intense:
    Code:
    <script type="text/javascript">top.charpane.location.href="charpane.php";</script><script type="text/javascript">if (window.updateInv) updateInv({"9481":-1})</script><script type="text/javascript">if (!window.updateInv && parent.mainpane.updateInv) parent.mainpane.updateInv({"9481":-1})</script><center><table  width=95%  cellspacing=0 cellpadding=0><tr><td style="color: white;" align=center bgcolor=blue><b>Results:</b></td></tr><tr><td style="padding: 5px; border: 1px solid blue;"><center><table><tr><td><p>You put on your winningest smile and prepare to engage and disengage from social interaction as needed.</p><center><table><tr><td><img class=hand src="https://s3.amazonaws.com/images.kingdomofloathing.com/itemimages/foldednote.gif" onClick='eff("3ae7ac0713f04156fd2b53a37b450b83");' width=30 height=30 alt=" Become Superficially interested" title=" Become Superficially interested"></td><td valign=center class=effect>You acquire an effect: <b> Become Superficially interested</b><br>(duration: 100 Adventures)</td></tr></table></center></blockquote></td></tr></table></center></td></tr><tr><td height=4></td></tr></table></center>
    Processing results...
    You acquire an effect: Become Superficially interested
    Processing result: Become Superficially interested (0)
    Processing result: Daily Affirmation: Be Superficially interested (-1)

  8. #8
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,119

    Default

    That would be a KoL bug, but we can work around it. Revision 19530 will trim() the effect name presented in bold. I did the same for item names, just in case, since neither effect nor item names begin or end with a space.

  9. #9
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,119

    Default

    (By the way: this is "Waiting for Info" for your confirmation I fixed it. )

  10. #10

    Default

    Sacremental is good. Superficial is good. Facial expressions look good. Thanks, Veracity.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •