Page 1 of 2 1 2 LastLast
Results 1 to 10 of 17

Thread: Combat Menu Buttons (custom buttons?) broken

Hybrid View

Previous Post Previous Post   Next Post Next Post
  1. #1

    Default Combat Menu Buttons (custom buttons?) broken

    I don't know the proper terminology, I mean the buttons at the top of the combat frame (within the relay browser, myself using Version 76.0.3809.87 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)). A week ago or so, their order got all jumbled up. And between yesterday (using version 19473) and today (using version 19475) all automatic line breaks are gone from that field, making some buttons not easily accessible anymore. I tried going back to version 19473 but without success, it looks the same (screenshot provided). Please advise if this is a bug or if some preference or data file of mine most likely got corrupted and needs fixing.
    Attached Images Attached Images

  2. #2
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,102

    Default

    We call those "Stationary Buttons", since they are in a fixed location at the top of the combat frame.

    They still work for me on OS X.

    Did you update Java recently?

    buttons.png

  3. #3

    Default


    Did you update Java recently?

    buttons.png
    Originally Posted by Veracity View Post
    I did on August 1.

    openjdk-11-jre-headless (11.0.3+7-1ubuntu2~18.04.1, 11.0.4+11-1ubuntu2~18.04.3) Upgraded at Do. Aug. 1 06:59:27 2019
    openjdk-11-jre (11.0.3+7-1ubuntu2~18.04.1, 11.0.4+11-1ubuntu2~18.04.3) Upgraded at Do. Aug. 1 06:59:27 2019
    edit: I guess that roughly tracks with when the first jumbled-up stationary button menu appeared, but the line breaks disappearing definitively happened after the most recent rollover to me.
    Last edited by Boesbert; 08-08-2019 at 06:02 PM.

  4. #4
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,102

    Default

    KoLmafia does not put line breaks into rows of buttons. All the buttons are in a row and it is 100% up to your browser to wrap them to fit.

    I guess I need to ask: have you changed or upgraded your browser? Changed anything at all in browser settings?

  5. #5

    Default

    KoLmafia does not put line breaks into rows of buttons. All the buttons are in a row and it is 100% up to your browser to wrap them to fit.

    I guess I need to ask: have you changed or upgraded your browser? Changed anything at all in browser settings?
    Originally Posted by Veracity View Post
    I did not change any settings but yes, I have been regularly upgrading Chromium (and there have been several upgrades recently).

    I just checked with Firefox and the problem does not appear there. I guess I might have to switch again...

  6. #6
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,102

    Default

    Ideally, we'd like to generate html/javascript which renders the same on all browsers.

    Looking at your screen shot and mine, it looks like the surrounding frames are not quite the same. Presumably a Browser difference.

    Can you do this for me, please.

    Go to Preferences/Extra Debugging
    Check "Log decorated responses in debug log"
    In gCLI, "debug on"
    In relay browser (Chromium) start a fight.
    - verify that the buttons are not wrapping as expected.
    In gCLI "debug off"

    In the DEBUG log, find the following two things:

    - The text returned by KoL for the fight request
    - The text as modified by KoLmafia which included the stationary buttons which is sent to the browser.

    I'd like to see if there is something different being sent from KoL than what I get. I am using "Google Chrome" now, because Firefox has issues for me.
    And I'd like to see if the KoLmafia-"decorated" text is different, somehow.

  7. #7

    Default

    In the DEBUG log, find the following two things:

    - The text returned by KoL for the fight request
    - The text as modified by KoLmafia which included the stationary buttons which is sent to the browser.
    Originally Posted by Veracity View Post
    This part is surprisingly difficult for me since I am not exactly sure where the beginning and end of those things are in this wall of text.

  8. #8
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,102

    Default

    OK, fair enough.

    If you turned on and off debugging as I suggested, your DEBUG file should be fairly small. Just attach the whole thing.

    (If you run Guide, it will probably include some extra requests/responses. I can deal with that.)

  9. #9

    Smile

    here you go
    Attached Files

  10. #10
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,102

    Default

    I didn't respond, although I should have, since I looked at your debug log.

    The HTML it creates for me is identical to the HTML it creates for you.
    I am currently using Chrome on my Mac as my Relay Browser, and the stationary buttons continue to render perfectly for me.
    You are using Linux, no? So "Chromium" for you is not exactly the same as "Chrome" for me, although I expect they have similar technology inside.
    But, sometime recently, "Chromium" stopped doing line wrapping the way it used to.

    Sorry to say, since this is not easily controllable, but this is a bug in your browser, rather than KoLmafia; the valid HTML that KoLmafia produces for Stationary Buttons has not changed for years - but your browser has changed how it renders it.

    Don't know what to suggest. But, this is not a KoLmafia bug.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •