Page 2 of 3 FirstFirst 1 2 3 LastLast
Results 11 to 20 of 21

Thread: Bug: Doctor Bag quest NC isnt being handled as part of combat

  1. #11

    Default

    Code:
    adv1(to_location("VYKEA"), -1, "");
    if (choice_follows_fight())
    {
      run_choice(-1);
    }
    still results in

    [70857] VYKEA
    Preference lastEncounter changed from angry tourist to Witchess Knight
    Encounter: Witchess Knight
    Preference _lastCombatStarted changed from 20190320073053 to 20190320073103
    Preference _sourceTerminalDigitizeMonsterCount changed from 2 to 3
    Preference relayCounters changed from 70856igitize Monster loc=* type=wander:watch.gif to
    Preference relayCounters changed from to 70896igitize Monster loc=* type=wander:watch.gif
    Preference _stinkyCheeseCount changed from 25 to 26
    Round 0: Malibu Stacey wins initiative!
    WHAM: Running SmartStasis
    Round 1: Malibu Stacey executes a macro!
    Round 1: Malibu Stacey casts SUMMON LOVE GNATS!
    Round 2: Light-Fingered Haroun chomps your foe on the arm and refuses to let go. That's that famous Saint Patrick tenacity at work.
    Round 2: Malibu Stacey casts EXTRACT!
    You acquire an item: Source essence
    Round 3: Malibu Stacey casts SING ALONG!
    WHAM: Starting evaluation and performing of attack
    WHAM: We are going to 1-shot with attack with your weapon.
    Round 4: Malibu Stacey executes a macro!
    Round 4: Malibu Stacey attacks!
    Round 5: Witchess Knight takes 3156 damage.
    Round 5: Malibu Stacey wins the fight!
    You gain 224 Meat
    After Battle: Light-Fingered Haroun shoots you a wink and does a little dance to disabuse onlookers of his nefarious intentions.
    You acquire an item: jumping horseradish
    You gain 41 Meat.
    After Battle: Saint Light-Fingered Haroun barks or howls or makes whatever sort of excited animal noise is appropriate for a thing like Light-Fingered Haroun, and this gets you pumped up. (+4 Muscle Stats)
    After Battle: You gain 30 Muscleboundness
    After Battle: You gain 30 Magicalness
    After Battle: You gain 58 Sarcasm
    After Battle: Light-Fingered Haroun takes advantage of the downtime to grab a few z's.
    After Battle: Light-Fingered Haroun takes note of any security cameras in the area.
    Preference testudinalTeachings changed from 150:5|211:2|203:5|267:0|266:1|198:1|213:0|207:2|20 6:4|214:5|210:5|197:2|269:3|209:3 to 150:5|211:2|203:5|267:1|266:1|198:1|213:0|207:2|20 6:4|214:5|210:5|197:2|269:3|209:3
    Preference _catBurglarCharge changed from 37 to 38
    Preference _catBurglarCharge changed from 38 to 39
    This combat did not cost a turn
    Preference walfordBucketProgress changed from 59 to 60
    Preference walfordBucketProgress changed from 60 to 61

    A choice follows this fight immediately.

    A choice follows this fight immediately.
    even though choiceAdventure1340=1

  2. #12
    Senior Member ckb's Avatar
    Join Date
    Mar 2006
    Posts
    971

    Default

    FWIW, running adv1() inside a while loop correctly handles the doctor bag adventure, choosing to ignore/dismiss it when choiceAdventure1340=3

  3. #13

    Default

    FWIW, running adv1() inside a while loop correctly handles the doctor bag adventure, choosing to ignore/dismiss it when choiceAdventure1340=3
    Originally Posted by ckb View Post
    Sounds like the core of the problem is mafia not handing a refresh of adventure.php when a choice follows an adventure (see Dictator's earlier post about Haunted Bedroom combats also not being handled similarly).
    Using a while loop as a workaround is the proverbial bandaid on a bullet hole.

  4. #14

    Default

    Is this fixed by 19204? It'll be a couple of days before I can test it as I have a doctor bag quest at present & I don't get through them too quickly.

  5. #15

    Default

    Is this fixed by 19204? It'll be a couple of days before I can test it as I have a doctor bag quest at present & I don't get through them too quickly.
    Originally Posted by Malibu Stacey View Post
    I doubt it.

  6. #16
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,161

    Default

    Bumping from page 12.

  7. #17

    Default

    Bumping from page 12.
    Originally Posted by Veracity View Post
    I think my issue in this thread is fixed by the recent changes to run_choice() but I was working around it using the following

    Code:
      adv1(to_location("VYKEA"), -1, "");
      if (choice_follows_fight()) {
        visit_url("choice.php");
        run_choice(-1);
      }
    thanks to discussion on that issue highlighting the need to manually call visit_url("choice.php"); (which I think may no longer be needed?)

  8. #18
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,161

    Default

    Yeah, I made run_choice do the visit_url itself if choice_follows_fight.

    I bumped this because the Doctor's Bag can interrupt adventuring anywhere, including places you are not expecting a choice, so, perhaps if you have set a default for that choice, we should automaically handle it for you? I need to think more about this and probably do some experimentation.

  9. #19
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,161

    Default

    I haven't tried the doctor's bag yet, since I've been testing stuff on characters that have no IOTMs, but I noticed this when automating a single adventure in the Haunted Bedroom.

    Code:
    Visit to Manor2: The Haunted Bedroom in progress...
    
    [847624] The Haunted Bedroom
    Encounter: Wardröb nightstand
    Round 0: Tebryn wins initiative!
    Round 1: Tebryn executes a macro!
    Round 1: Tebryn attacks!
    Round 2: Wardröb nightstand takes 5269 damage.
    Round 2: Wingwang shakes loose a considerable quantity of spice. You conjure up a canister and collect it.
    You acquire an item: spices
    Round 2: Tebryn wins the fight!
    After Battle: Wingwang demonstrates a dance of celebration from his native land. Translated into couscous, it's basically incomprehensible.
    After Battle: You gain 1 Fortitude
    After Battle: You gain 15 Mysteriousness
    After Battle: You gain 7 Smarm
    
    Requests complete.
    
    > choice
    
    You aren't in a choice adventure.
    
    > ash choice_follows_fight()
    
    Returned: true
    This is the same issue as the Doctor's Bag, and is easily reproducible for any of my test characters.

  10. #20
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    13,161

    Default

    Revision 19901 fixes KoLmafia.executeAdventureOnce to detect that choice_follows_fight and, if so, request choice.php and then automate the choice.

    The new code:

    Code:
    		RequestThread.postRequest( adventure );
    		if ( FightRequest.choiceFollowsFight )
    		{
    			RequestThread.postRequest( new GenericRequest( "choice.php" ) );
    			ChoiceManager.gotoGoal();
    		}
    Looks suspiciously like your:

    Code:
      adv1(to_location("VYKEA"), -1, "");
      if (choice_follows_fight()) {
        visit_url("choice.php");
        run_choice(-1);
      }

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •