Feature - Implemented New item_type "potion"

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
It seems most items in the "potion" category (http://kol.coldfront.net/thekolwiki/index.php/Potion) are either "avatar potion" (which is fine) or "". Would there be any reason not to track these? I was personally going to use it to write a script to see profitable duplication targets for the Machine Elf.
 

Darzil

Developer
I don't understand the request. Where are they "", and what would we be tracking by "" ?

As you say, you can work out Avatar potions by the fact they give an effect with an "Avatar" modifier.
 

heeheehee

Developer
Staff member
Not exclusively. For instance, chocolate cigars are classified as "potion" but do not give an effect.

chocolate cigar
This is a cigar made from a blend of fine chocolate and fine tobacco, so as to appeal to both outmoded gender stereotypes at the same time. It's fancy and sophisticated, if a little impractical.

Type: potion
Cannot be discarded
 

heeheehee

Developer
Staff member
Also, on the flip side, birthday candle is an item that is usable, grants an effect, but not a potion. I would be shocked to see that as the only example, even if we restrict to Mafia's notion of "usable", excluding "reusable".

Ran the following:
ashq foreach it in $items[] if (it.usable && !it.reusable && it.effect_modifier("Effect") != $effect[none]) print(it);:

which indicates that I'd need something more sophisticated, since I really want items with primary use == "usable". A manual attempt at editing this data yields the surprisingly short list:
Code:
1/6th Pound Cake
37x37x37 puzzle cube
Aerheads
all-purpose cleaner
Angry Farmer's Wife Candy
astral mushroom
Atomic Comic
augmented-reality shades
bag of pygmy blood
ballast turtle
banana supersucker
bazookafish bubble gum
beet-flavored Mr. Mediocrebar
Bettie page
bitter pill
black and white cracker
black tear
blue potion
boiling broth
Boosty Juice
bottle of goofballs
Bright Water
cabbage-flavored Mr. Mediocrebar
candied bolts
candied nuts
candy crayons
candy UFOs
can of V-11
cartoon heart
celestial au jus
celestial olive oil
celestial squid ink
Cheer-Up soda
children of the candy corn
cocoa chondrule
cold seal sweat
confiscated cell phone
confiscated comic book
confiscated love note
correction fluid
corrupted data
Crimbot battery
cursed wishbone
Daffy Taffy
daub-breaker
Deep Machine Tunnels snowglobe
demonic cow's blood
elderly jawbreaker
elven suicide capsule
essential cameraderie
essential soy
evil vihuela
extra-strength red potion
Fabiotion
fancy blue potion
fiberglass insulation
fitness wristband
Flan in the Moon
foetid seal tear
Fudge Fiber Armor Plating
Fun-Guy spore
Gabarbar
gingerbread spice latte
glowing El Vibrato drone
Good 'n' Quiet
Good 'n' Slimy
grisly shell fragment
gummi ammonite
gummi belemnite
gummi trilobite
handful of Crotchety Pine needles
handful of Laughing Willow bark
heather graham cracker
holy spring water
honeypot
hot button candy
humming El Vibrato drone
hyperinflated seal lung
interrogative elixir
invisible seam ripper
invisible string
jagged tooth
Jamocha berry
Keese berry
Knob Goblin firecracker
Kokomo Resort Brand Suntan Oil
labrador cookie
lime supersucker
liquid ice pack
liquid rhinestones
Love Potion #XYZ
lump of Saccharine Maple sap
M-242
Mer-kin rocksalt
Mer-kin saltmint
Mer-kin saltsquid
mime army camouflage kit
moose thought
murderbot spring injector
mystery lollipop
Nadsat berry
new habit
Nightstalker perfume
patchouli incense stick
pear supersucker
PEEZ dispenser
perl necklace
piece of after eight
pill cup
pitted sheet metal
polyeaster egg
porcelain candy dish
potion of animal rage
potion of the captain's hammer
potion of X-ray vision
powdered candy sushi set
powdered dice
powdered toad horn
pressurized potion of pneumaticity
primitive alien medicine
Puffstone cigar
pygmy phone number
Rattlin' Chains
recording of Rolando's Rondo of Resisto
Red Pill
red potion
roofie
ruby on canes
runproof mascara
sacramental wine
scroll of Puddingskin
seal eyeball
sealhide seal doll
sharkfin gumbo
snake
Snarf berry
sodium pentasomething
sparkler
spirit beer
strawberry supersucker
superwater
Super Weight-Gain 9000
sweet-corn-flavored Mr. Mediocrebar
sweetened reindeer fat
talisman of Horus
Tapioc berry
tempura air
That 70s Cologne
Threatening Missive
tiny bottle of absinthe
tonic o' Banderas
too legit potion
toothbrush
Ultrasoldier Serum
Uncle Greenspan's Bathroom Finance Guide
universal antivenin
vial of brown slime
wad of cotton
warbear bearserker potion
warbear liquid lasers
warbear rejuvenation potion
warbear superpotion
warbear wardance potion
warm El Vibrato drone
wind-up meatcar

I see fancy blue potion (and presumably other restorers) are also incorrectly classified as potions, per this criteria.
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Yeah to clarify I was referring to the result of passing the item to item_type, for which "" is the result when the item does not have a type.
 

Darzil

Developer
So what do you want to see in item_type for items without an item type? Please spell out what you want to see, with examples if necessary, for the hard of thinking (me).
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Right maybe I have a misunderstanding of what item_type actually does. There are a number of items in the game the description page for which say "Type: potion", and I would like to be able to make a subset of the item list that contain items for which that is the case. I don't think examples I gave would be any better than the ones that heeheehee gave though.
 

Veracity

Developer
Staff member
I think it's reasonable that for all items that KoL itself says are "Type: potion" that we define them to be a "potion" and make their potionhood accessible to scripts.
It'd require a backfill for existing items and also recognizing that in new-item detection.
 

heeheehee

Developer
Staff member
Potions that show up in a mall search (sans prices):

Code:
"DRINK ME" potion
37x37x37 puzzle cube
8-bit banana
abominable blubber
adder bladder
Aerheads
airborne mutagen
alien drugs
alphabet gum
Ancient Protector Soda
Angry Farmer candy
Angry Farmer's Wife Candy
ant agonist
arse-a'fire elixir
ash soda
astral mushroom
Atomic Comic
Atomic Pop
augmented-reality shades
bag of Cheat-Os
bag of grain
bag of lard
bag of pygmy blood
bag of W&Ws
baggie of powdered sugar
bakelite-covered bacon
banana smoothie
banana supersucker
baobab sap
basaltamander tongue
bazookafish bubble gum
beard incense
beet-flavored Mr. Mediocrebar
begpwnia
bellhop bell
Ben-Gal™ Balm
bent scrap metal
Bettie page
big dribbly candle
Big Punk
Bit O' Ectoplasm
Bit O' Quail Spleen
bitter pill
BitterSweetTarts
black and white cracker
Black Body™ spray
black eye shadow
black eyedrops
black facepaint
Black No. 2
black sheepskin diploma
black snowcone
black tear
blackberry polite
blob of Alphredo™
Blood 'n' Plenty
blood of the Wereseal
bloodstain stick
blue grass
blue snowcone
blue-frosted astral cupcake
boiling broth
boiling seal blood
Boletus Broletus mushroom
bone bons
Boosty Juice
BOOterfinger
Boss Drops
bottle of antifreeze
bottle of black cat tonic
bottle of bubbles
bottle of fire
bottle of lighter fluid
bottle of limeade
bottle of Mystic Shell
bottle of pirate juice
bottle of rhinoceros hormones
bottled inspiration
bowl of Jeal-O
bowl of marinade
box of Dweebs
breath mint
Bright Water
BROS Energy Drink
Bruno's blessing of Mars
bubbly potion
buffed alien drugs
Bugbearclaw Donut
Burt's blessing of Bacchus
buzzard feather
cabbage-flavored Mr. Mediocrebar
can of Binarrrca
can of black paint
Can of Spaghetto
can of spinach
can of V-11
candied bolts
candied kobold
candied nuts
candy brain
candy cigarette
candy crayons
candy skeleton
candy UFOs
catfish whiskers
celestial au jus
celestial carrot juice
celestial olive oil
celestial squid ink
chakra malt
charisma potion
cheap cigar butt
Cheer-Up soda
chicle de salchicha
children of the candy corn
choco-Crimbot
chocolate cigar
chocolate disco ball
chocolate filthy lucre
chocolate pasta spoon
chocolate saucepan
chocolate seal-clubbing club
chocolate stolen accordion
chocolate turtle totem
chocolate-covered caviar
chunk of rock salt
cigar box turtle
Climate Colada
Cloaca Cola Polar
cloudy potion
coal dust
cocoa chondrule
Cold Hots candy
cold nuggets
cold powder
cold seal sweat
cold-filtered water
cologne of contempt
colorful toad
comb jelly
Comet Drop
communal gobstopper
concentrated cordial of concentration
concentrated garbage juice
concoction of clumsiness
confiscated cell phone
confiscated comic book
confiscated love note
Connery's Elixir of Audacity
cool cat elixir
cordial of concentration
correction fluid
corrupted data
corrupted marrow
cosmic lemonade
cranberry cordial
crappy waiter disguise
Crimbo candied pecan
Crimbo fudge
Crimbo peppermint bark
Crimbot battery
crude crudités
CSA bravery badge
cube of billiard chalk
cuppa Alacri tea
cuppa Boo tea
cuppa Chari tea
cuppa Craft tea
cuppa Dexteri tea
cuppa Feroci tea
cuppa Flamibili tea
cuppa Flexibili tea
cuppa Frost tea
cuppa Gill tea
cuppa Impregnabili tea
cuppa Improprie tea
cuppa Insani tea
cuppa Irritabili tea
cuppa Loyal tea
cuppa Mana tea
cuppa Mediocri tea
cuppa Monstrosi tea
cuppa Morbidi tea
cuppa Nas tea
cuppa Net tea
cuppa Neuroplastici tea
cuppa Obscuri tea
cuppa Physicali tea
cuppa Proprie tea
cuppa Serendipi tea
cuppa Toast tea
cuppa Twen tea
cuppa Uncertain tea
cuppa Vitali tea
cuppa Wit tea
cuppa Yet tea
cursed wishbone
cyclops eyedrops
Daffy Taffy
Daily Affirmation: Adapt to Change Eventually
Daily Affirmation: Always be Collecting
Daily Affirmation: Be a Mind Master
Daily Affirmation: Be Superficially interested
Daily Affirmation: Keep Free Hate in your Heart
Daily Affirmation: Think Win-Lose
Daily Affirmation: Work For Hours a Week
dark potion
daub-breaker
deadly lampshade
Deep Machine Tunnels snowglobe
delicious candy
delicious comfit?
demonic cow's blood
Dennis's blessing of Minerva
dented spoon
deodorant
desktop zen garden
devilish folio
digital underground potion
diluted makeup
disco horoscope (Aquarius)
disco horoscope (Aries)
disco horoscope (Cancer)
disco horoscope (Capricorn)
disco horoscope (Gemini)
disco horoscope (Leo)
disco horoscope (Libra)
disco horoscope (Pisces)
disco horoscope (Sagittarius)
disco horoscope (Scorpio)
disco horoscope (Taurus)
disco horoscope (Virgo)
disintegrating spiky collar
Doc Galaktik's Vitality Serum
dog ointment
Dogsgotnonoz pills
dollop of barbecue sauce
donkey flipbook
double-ice gum
Drizzlers™ Black Licorice
drop of water-37
drum of pomade
Drunk Uncles holo-record
dubious peppermint
eagle feather
Eau de Guaneau
ectoplasmic orbs
eel battery
Effermint™ tablets
effervescent potion
elderly jawbreaker
eldritch alignment spray
eldritch concentrate
eldritch oil
eldritch rub
Elizabeth's paintbrush
elven suicide capsule
Elvish delight
EMD holo-record
essential cameraderie
essential soy
Everlasting Deckswabber
exotic travel brochure
experimental serum G-9
experimental serum P-00
extra-potent gremlin mutagen
eyedrops of newt
eyedrops of the ermine
eyedrops of the ocelot
Fabiotion
fabric hardener
fake blood
fake cocktail
fancy but probably evil chocolate
fancy chocolate
fancy chocolate car
Ferrigno's Elixir of Power
fiberglass insulation
finger exerciser
fire flower
fish juice box
fish-liver oil
fitness wristband
fizzy potion
flask of baconstone juice
flask of hamethyst juice
flask of mining oil
flask of porquoise juice
flask of tainted mining oil
Flaskfull of Hollow
floaty sand
fluid of fudge-finding
foetid seal tear
Freddie's blessing of Mercury
freezer-burned frost-bitten tortellini
freezerburned ice cube
Friendliness Beverage
Frogade
frost flower
frostbite-flavored Hob-O
frozen shampoo-conditioner
fruitfilm
fry-oil-flavored Hob-O
Fudge Fiber Armor Plating
fudge lily
fudge-shaped hole in space-time
Fun-Guy spore
funky dried mushroom
funny bone
future drug: Coolscaline
future drug: Muscularactum
future drug: Smartinex
Gabarbar
garbage-juice-flavored Hob-O
gazely stare
Gene Tonic: Beast
Gene Tonic: Constellation
Gene Tonic: Construct
Gene Tonic: Demon
Gene Tonic: Dude
Gene Tonic: Elemental
Gene Tonic: Elf
Gene Tonic: Fish
Gene Tonic: Goblin
Gene Tonic: Hippy
Gene Tonic: Hobo
Gene Tonic: Horror
Gene Tonic: Humanoid
Gene Tonic: Insect
Gene Tonic: Mer-kin
Gene Tonic: Orc
Gene Tonic: Penguin
Gene Tonic: Pirate
Gene Tonic: Plant
Gene Tonic: Slime
Gene Tonic: Undead
Gene Tonic: Weird
ghost bit
ghost thread
giant giant moth dust
ginger snaps
gingerbread spice latte
giraffe-necked turtle
glittery mascara
Glo-Pop
glob of spoiled mayo
glowing syringe
go-go potion
goblin water
Good 'n' Quiet
Good 'n' Slimy
gourmet gourami oil
government
graveyard snowglobe
Greek fire
green candy heart
green rock candy
green snowcone
green-frosted astral cupcake
gremlin juice
gremlin mutagen
grisly shell fragment
groupie spangles
gummi ammonite
gummi belemnite
gummi canary
gummi fang
gummi salamander
gummi snake
gummi trilobite
gummi turtle
Gummi-DNA
Gummi-Gnauga
Gummy Brains
gun cleaning kit
Gyromitra Dynomita mushroom
haggis-infused soap
hair of the fish
hair oil
hair spray
half-baked potion
half-digested coal
half-orchid
handful of crafty noodles
handful of Crotchety Pine needles
handful of hand chalk
handful of Laughing Willow bark
handful of pine needles
handsomeness potion
hare brush
Hawking's Elixir of Brilliance
heather graham cracker
Helvella Haemophilia mushroom
hemp candy necklace
henna face paint
henna tattoo
Hersey™ SMOOCH
hi-octane carrot juice
high-test fishing line
hoarded candy wad
holly-flavored Hob-O
honey stick
Hot 'n' Scarys
hot button candy
hot coal
hot nuggets
hot powder
How to Avoid Scams
Hunger™ Sauce
industrial strength starch
Inner Strength
Inner Truth
Inner Wisdom
interrogative elixir
invisibility potion
invisible potion
ironic mint
irradiated pet snacks
irradiated turtle
irresistibility potion
irritability potion
jabañero-flavored chewing gum
jagged tooth
jar of "Creole Lady" marrrmalade
jellyfish gel
Jokester makeup
jug of "wine"
jug of baconstone juice
jug of hamethyst juice
jug of porquoise juice
Knob Göblin lòve potion
Knob Goblin eyedrops
Knob Goblin learning pill
Knob Goblin love potion
Knob Goblin nasal spray
Knob Goblin perfume
Knob Goblin pet-buffing spray
Knob Goblin sharpening spray
Knob Goblin steroids
Kokomo Resort Brand Suntan Oil
Kokomo Resort Pass
kumquat supersucker
lavender candy heart
lemonhead caviar
lesser grodulated violet
libation of liveliness
licorice root
lime supersucker
lime-and-chile-flavored chewing gum
lion musk
liquid ice
liquid ice pack
liquid rhinestones
liquid smoke
little red jam
llama lama gong
Lobos Mints
lotion of coldness
lotion of hotness
lotion of sleaziness
lotion of spookiness
lotion of stench
LOV Elixir #3
LOV Elixir #6
LOV Elixir #9
love song of disturbing obsession
love song of icy revenge
love song of naughty innuendo
love song of smoldering passion
love song of sugary cuteness
love song of vague ambiguity
Lucky Strikes holo-record
lump of Saccharine Maple sap
lynyrd musk
M-242
mafia aria
magicberry tablets
mangled finger
mariachi toothpaste
Marvin's marvelous pill
marzipan skull
Mayo de Mayo™ mayo
Meat-inflating powder
Meleegra™ pills
Mer-kin cooljuice
Mer-kin fastjuice
Mer-kin hidepaint
Mer-kin lipstick
Mer-kin ragejuice
Mer-kin rocksalt
Mer-kin saltmint
Mer-kin saltsquid
Mer-kin smartjuice
Mer-kin strongjuice
Mick's IcyVapoHotness Inhaler
Mick's IcyVapoHotness Rub
milk of magnesium
Milk Studs
milky potion
miniature power pill
mocking turtle
monkey barf
Moonds
moose thought
Mortimer's nostrum
mostly-broken sunglasses
mother's little helper
mouse skull
Mr. Mediocrebar
murderbot shield unit
murderbot spring injector
murky potion
musk turtle
mysterious chemical residue
mystery lollipop
nail file
nasty gum
natto marble soda
Necbro wafers
neurostim pill
new habit
Nightstalker perfume
Northern pemmican
Now and Earlier
Nuclear Blastball
O'RLY manual
Ogres and Oubliettes™ module
oil of expertise
oil of oiliness
Oil of Parrrlay
oil of slipperiness
oil of stability
ointment of the occult
Okee-Dokee soda
old bronzer
old candy wrapper
old eyebrow pencil
old love note
old rosewater cream
Omphalotus Omphaloskepsis mushroom
one pill
orange and black Crimboween candy
orange candy heart
orange snowcone
orange-frosted astral cupcake
orcish hand lotion
orcish nailing lube
orcish rubber
Outer Wolf™ cologne
Pain Dip
pair of candy glasses
panty raider camouflage
papotion of papower
patchouli incense stick
patent aggression tonic
patent alacrity tonic
patent avarice tonic
patent invisibility tonic
patent preventative tonic
patent sallowness tonic
peach lozenge
pear lozenge
pear supersucker
pec oil
PEEZ dispenser
peppermint twist
perfume of prejudice
perl necklace
ph balancer
phial of coldness
phial of hotness
phial of sleaziness
phial of spookiness
phial of stench
philter of phorce
physiostim pill
pickle-flavored chewing gum
Piddles
piece of after eight
pill cup
pine tar
pink candy heart
pink-frosted astral cupcake
pirate brochure
pirate pamphlet
pirate tract
pitted sheet metal
pixel star
pixellated candy heart
PlexiPips
plum lozenge
pocket maze
Pokëmann band-aid
poker face paint
Polka Pop
polo trophy
polyeaster egg
Polysniff Perfume
poppy
porcelain candy dish
portable wall
possibility potion
post-holiday sale coupon
potent potion of potency
potion of animal rage
Potion of Heroism
potion of potency
potion of punctual companionship
potion of spiritual gunkifying
potion of temporary gr8tness
potion of the captain's hammer
potion of the field gar
potion of the litterbox
potion of X-ray vision
powdered candy sushi set
powdered dice
powdered toad horn
power pill
Power-Guy 2000 holo-record
pressurized potion of perception
pressurized potion of perspicacity
pressurized potion of proficiency
pressurized potion of puissance
pressurized potion of pulchritude
primitive alien medicine
probability potion
programmable turtle
Prunets
pulled blue taffy
pulled green taffy
pulled indigo taffy
pulled orange taffy
pulled red taffy
pulled violet taffy
pulled yellow taffy
pumpkin juice
Punching Potion
purple snowcone
purple-frosted astral cupcake
pygmy phone number
pygmy pygment
Rümpelstiltz
Rad-Pro (1 oz.)
rainbow jellybean
rattler gland
Rattlin' Chains
really thick spine
recording of Benetton's Medley of Diversity
recording of Chorale of Companionship
recording of Donho's Bubbly Ballad
recording of Elron's Explosive Etude
recording of Inigo's Incantation of Inspiration
recording of Prelude of Precision
recording of Rolando's Rondo of Resisto
recording of The Ballad of Richie Thingfinder
red blood cells
red eye
red foxglove
red letter
Red Pill
red snowcone
reodorant
resolution: be feistier
resolution: be happier
resolution: be kinder
resolution: be luckier
resolution: be more adventurous
resolution: be sexier
resolution: be smarter
resolution: be stronger
resolution: be wealthier
rhinestone
ribbon candy
robin's egg
robot grease
Rock Pops
roll of meat
roofie
rubber nubbin
ruby on canes
runproof mascara
salamander slurry
salt wages
scrap metal
scroll case
scroll of Protection from Bad Stuff
scroll of Puddingskin
sea grease
sea salt crystal
seal-brain elixir
seegar butt
Senior Mints
sensitive poetry journal
serum of sarcasm
shady shades
shark cartilage
sharkfin gumbo
shavin' razor
Shielding Potion
shoe gum
shoulder-warming lotion
Shrieking Weasel holo-record
shrimp cocktail
Shrubble Bubble
silver face paint
single of Donho's Bubbly Ballad
single of Inigo's Incantation of Inspiration
skin oil
sleaze nuggets
sleaze powder
sludgesicle
small gummi fin
smart watch
smoky potion
smudge stick
snake
snow cleats
sorority brain
sour powder
Spant eggs
sparkler
Spechunky bar
SPF 451 lip balm
spidercow eye-cluster
spirit gum
spooky eyeliner
spooky lipstick
spooky nuggets
spooky powder
spooky sap
spooky sound effects record
spoonful of Linguine-Os
Squat-Thrust Magazine
squeaky toy rose
Steal This Candy
Stemonitis Staticus mushroom
stench nuggets
stench powder
Stephen's secret formula
sterno-flavored Hob-O
sticky lava globs
stone wool
strawberry supersucker
strawberry-flavored Hob-O
sugar banana
sugar bunny
sugar cherry
Sugar Cog
sugar fairy
sugar lime
sugar sphere
sugar-coated pine cone
Super Weight-Gain 9000
super-spiky hair gel
Superdrifter holo-record
Swabbie™ swab
swamp lolly
sweet mochi ball
Sweet Sword
sweet-corn-flavored Mr. Mediocrebar
sweetened reindeer fat
swirly potion
Swizzler
Taco Dan's Taco Stand Chillacious Churro
tainted icing
Take Eleven Bar
Tallowcreme Halloween Pumpkin
tamarind-flavored chewing gum
tangled mass of creepy pasta
Tasty Fun Good rice candy
teeny-tiny magic scroll
temporary teardrop tattoo
temporary X tattoos
Texas tea
that gum you like
the most dangerous bait
The Pigs holo-record
They liver
thin black candle
tightly-wound spine
tin cup
tin magnolia
tiny bottle of absinthe
tiny dancer
tobiko marble soda
tomato juice of powerful power
tonic o' Banderas
too legit potion
transporter transponder
Tremella Tarantella mushroom
triggerfingerbone
true grit
tube of dread wax
turtle voicebox
twinkly nuggets
twinkly powder
Ultrasoldier Serum
Uncle Greenspan's Bathroom Finance Guide
unstable DNA
unusual oil
upsy daisy
vial of baconstone juice
vial of blood simple syrup
vial of hamethyst juice
vial of porquoise juice
vial of The Glistening
violent pastilles
vitachoconutriment capsule
VYKEA woadpaint
warbear bearserker potion
warbear liquid lasers
warbear liquid overcoat
warbear rejuvenation potion
warbear robo-camouflage unit
warbear superpotion
warbear wardance potion
wasabi marble soda
Wax Flask
weremoose spit
wet venom duct
Whenchamacallit bar
white blood cells
white candy heart
Wickers bar
willyweed
wind-up ensign
wind-up meatcar
wind-up navigation droid
wind-up owl
wind-up vampire teeth
wind-up Whatsian robot
Wint-O-Fresh mint
witch's brew
worst candy
Wrotz
Ye Olde Bawdy Limerick
yellow candy heart
yellow pixel potion
Yolo™ chocolates
Yummy Tummy bean

This is a much longer list than the first one. It looks like my previous pruning was much too aggressive (in particular, it removed items marked as multi-usable), There are also some items that can't be sold in the mall (gift items, no-trade items) that are also in this category (black candy heart, evil vihuela, etc).
 

zarqon

Well-known member
A few other suggestions for item types:

- currency
- tattoo
- seeds
- monster (items that lead to fights, like copies and Carrronch's map)
- dwelling
- skillbook

Also, oddly, shotgun, Bananubis's Staff, and murderbot plasma rifle are not considered weapons according to item_type().
 

Veracity

Developer
Staff member
Bumping this, since it affects something I just implemented, and is therefore more likely to be something I am personally interested in seeing implemented. ;)
 

Saklad5

Member
Rather than indicating things like skillbooks with manually designated values like item_type, I think the focus should be on identifying them based on their in-game attributes. In that case, we should overload to_skill() to accept items, and track them that way. That’s just my opinion, of course.

If we start throwing a bunch of functionality at a single string proxy record field, it might get a bit hard to maintain.
 

Veracity

Developer
Staff member
Also, oddly, shotgun, Bananubis's Staff, and murderbot plasma rifle are not considered weapons according to item_type().
shotgun is a "ranged weapon (1-handed )", Bananubis's Staff is a "weapon (1-handed )" and murderbot plasma rifle is a "ranged weapon (2-handed rifle)".

That last one must have been fixed in KoL' description text.
Revision 19373 fixes item type for those - as well as anything else that is simply "1-handed " or "2-handed ".
 

Veracity

Developer
Staff member
Revision 19374 defines a new primary usage for items - "potion". If the primary usage is "potion" or "avatar", that accounts for everything that KoL tags as a "potion" in the item description. You can put "usable" or "multiple" as a secondary usage.

I changed "checkitems" to require items to be "potion" or "avatar" in order to match KoL description that says "potion". This made it tag hundreds of "usable" and "multiple" items as should-be potions. I modified every one of those to be "potion, usable" or "potion, multiple", as appropruate. "checkitems" no longer finds any errors.

I tried new item recognition by commenting out the various chewing gums from south of the border and then logging in to a character that had them.

Code:
Looking at item #297...
Unknown item found: tamarind-flavored chewing gum (297, 955502325)
-------------------
297	tamarind-flavored chewing gum	955502325	chicle.gif	potion, usable	t,d	20
Item	tamarind-flavored chewing gum	Effect: "Tamarind Torment", Effect Duration: 5
--------------------
Looking at item #298...
Unknown item found: lime-and-chile-flavored chewing gum (298, 278245380)
--------------------
298	lime-and-chile-flavored chewing gum	278245380	chicle.gif	potion, usable	t,d	20
Item	lime-and-chile-flavored chewing gum	Effect: "Spicy Limeness", Effect Duration: 5
--------------------
Looking at item #299...
Unknown item found: pickle-flavored chewing gum (299, 238820559)
--------------------
299	pickle-flavored chewing gum	238820559	chicle.gif	potion, usable	t,d	20
Item	pickle-flavored chewing gum	Effect: "Mystic Pickleness", Effect Duration: 5
--------------------
Looking at item #300...
Unknown item found: jabañero-flavored chewing gum (300, 653201781)
--------------------
300	jabañero-flavored chewing gum	653201781	chicle.gif	potion, usable	t,d	20
Item	jabañero-flavored chewing gum	Effect: "Spicy Mouth", Effect Duration: 5
--------------------
That's correct - except they are multiusable, but since we didn't detect them with a "rel string" we can't know that.

ASH item_type() behaves like this now:

Code:
[color=green]> ash item_type( $item[ stone golem pebbles ] )[/color]

Returned: avatar potion

[color=green]> ash item_type( $item[ pickle-flavored chewing gum ] )[/color]

Returned: potion
Lets keep an eye on this and see if I missed anything. If not, I think this does what this feature request is asking for.
 

Veracity

Developer
Staff member
There have been bugs, but they have been fixed and none are outstanding. Marking this Implemented.
 
Top