Page 2 of 2 FirstFirst 1 2
Results 11 to 19 of 19

Thread: 'acquire print screen button' fails if the coinmaster is sold out

  1. #11

    Default

    It is not autoBuyPriceLimit. That has nothing to do with mafia trying to buy it from the NPC shop (visible in the copy-pasted output in the first post).

  2. #12
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,628

    Default

    It is not autoBuyPriceLimit. That has nothing to do with mafia trying to buy it from the NPC shop (visible in the copy-pasted output in the first post).
    Originally Posted by lostcalpolydude View Post
    > acquire print screen button

    Verifying ingredients for print screen button (1)...
    Purchasing print screen button (1 @ 111 BACON)...
    Visiting the Internet Meme Shop...
    Internet Meme Shop successfully looted!
    Creation failed, no results detected.

    > ashq buy(1, $item[print screen button])

    Searching for "print screen button"...
    Search complete.
    Purchasing print screen button (1 @ 34,999)...
    Purchases complete.
    Since acquire was being used, the behavior I expect is that it will iterate over the acquisition methods in order from lowest to highest cost until the item is acquired. I interpreted the output as saying it first tried the NPC store and failed because it was "out of stock". It then tried the mall and failed, presumably because autoBuyPriceLimit was less than 34,999.

    Is my expectations of how acquire works incorrect or could the buy limit be a factor after the NPC purchase is unsuccessful?
    Well, thank you.
    Originally Posted by Veracity View Post

  3. #13

    Default

    Creation failed, no results detected.
    That results in an error state. The bug is that mafia uses a server hit trying to buy from the coinmaster (when it should know that it can't), and then the failure means the mall purchase is never attempted.

  4. #14
    Developer fronobulax's Avatar
    Join Date
    Feb 2009
    Location
    Central Virginia, USA
    Posts
    4,628

    Default

    That results in an error state. The bug is that mafia uses a server hit trying to buy from the coinmaster (when it should know that it can't), and then the failure means the mall purchase is never attempted.
    Originally Posted by lostcalpolydude View Post
    Thank you. Then this is a bug or FR because acquire does not continue after the first failure? Apologies if that was obvious to everyone else, but I just figured it out.
    Well, thank you.
    Originally Posted by Veracity View Post

  5. #15
    Developer
    Join Date
    Aug 2009
    Posts
    2,975

    Default

    Well, not quite. I'd argue that the bug is that acquire doesn't respect the pref (and tries to acquire from the coinmaster in the first place).

    Might just need an entry in CoinMastersDatabase.availableItem() and possibly also purchaseLimit().

  6. #16
    Developer
    Join Date
    Apr 2010
    Posts
    5,134

    Default

    I think it is that somewhere, it checks if the item exists in the coinmaster database (it does) rather than that it is purchasable (it isn't).

  7. #17
    Developer
    Join Date
    Aug 2009
    Posts
    2,975

    Default

    Ah, it's in MemeShopRequest.canBuyItem(), which only seems to be checked (in this particular execution) in CoinMasterRequest.buy().

    Good news, I guess, is that it doesn't invoke an unnecessary server hit as is.

  8. #18
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,936

    Default

    I'm interested in having Coinmasters work correctly, so, bumping from page 31.
    Ph'nglui mglw'nafh Cthulhu
    R'lyeh wgah-nagl fhtagn.

  9. #19
    Developer Veracity's Avatar
    Join Date
    Mar 2006
    Location
    The Unseelie Court
    Posts
    12,936

    Default

    Revision 19917

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •