Bug - Fixed missing modifiers

ckb

Minion
Staff member
Inspired by Veracity and this thread, I have found some other inconsistencies with modifiers:

> Items need effects/duration:
rook cookie
king cookie
queen cookie
knight cookie

> needs effect duration:
crappy waiter disguise
frostbite-flavored Hob-O
gremlin mutagen
magicberry tablets
PlexiPips
Wax Flask

For the second group, these are all 'Effect Duration: 1'
Some items that have an Effect Duration: 1 have this listed in modifiers, some do not. For consistency, I think it should be added to all.

examples [ with alias mods => ash string_modifier($string[%%],"Evaluated Modifiers") ]
> mods black tear
Returned: Effect: "Weepy, Creepy", Effect Duration: 1
> mods gummi canary
Returned: Effect: "Gummiskin", Effect Duration: 1
 

Veracity

Developer
Staff member
There are actually lots and lots of foods and boozes that have effects & effect durations that we don't have listed in modifiers.txt.

I made "checkitems" check Foods and Boozes and added appropriate sections to modifiers.txt.

For the things with Effect Duration: 1, the regular expression was looking for <b>X Adventures</b> and obviously "1 Adventure" does not match that.

Revision 14192 should fix all of this.
 
Top