Search results

  1. F

    Feature ChoiceManager refactor

    Don't mix "relevance" with "it was the subject". It is "relevant" to my proposed patch (which was not proposed in this thread), yes, but it was not "mentioned" here. The statement was that the recent discussion was about what needed to changed in said proposal for it to be accepted. That much is...
  2. F

    Feature ChoiceManager refactor

    But there was no proposal yet. The statement was, objectively, false.
  3. F

    Feature ChoiceManager refactor

    Well, it seems like those issues have not been clearly stated. There have been two "issues" raised so far: the (possible) separation of the choice adventures into more than one file, and the method used to "make" each choice adventure. In that discussion, no conclusion was reached, and the...
  4. F

    Feature ChoiceManager refactor

    Any development with this? @Veracity are there still arguments left in favour of having everything in a single file?
  5. F

    Bug "Comparison method violates its general contract!"

    Additionally, to point further towards threading being the issue: I ran the exact same test three times. The first time gave the error above. The second time didn't give an error, and the third gave this slightly different error (note the last two lines; this time, the exception was thrown from...
  6. F

    Bug "Comparison method violates its general contract!"

    I'm not sure what you're asking here. I'm already showing what class/method is the issue in the first image, in that it's net.sourceforge.kolmafia.persistence.AdventureDatabase.find(String), at line 851, which is a call to Arrays.sort(Object[]). On top of the fact that no comparison method is...
  7. F

    Bug "Comparison method violates its general contract!"

    Not *entirely* sure of what is happening here, but I think nameArray is a cached array version of nameList (as it is not referenced anywhere else), but was not made thread-safe (there are currently multiple scripts being parsed at once, with maybe two at once accessing this method), so one...
  8. F

    Feature ASH language server features

    There might be a misunderstanding regarding what this "is". This is a language server. The purpose of a language server is to connect to a language client (which are each hooked to a respective text editor, most notably IDEs). While a portion of IDEs support the LSP natively, the majority of...
  9. F

    Feature ASH language server features

    Am I waiting for people to try the prototype, or am I meant to continue/start its formal integration into KoLmafia?
  10. F

    Feature ASH language server features

    I submitted a prototype, btw
  11. F

    Feature ASH language server features

    Also, IIRC, that doesn't work for relay scripts, which need to be at the top-level of /relay
  12. F

    Feature ASH language server features

    It doesn't work if you use more than one folder (by which I mean, if you're storing something in /images or /data)
  13. F

    Feature ASH language server features

    That was, by the way, the reason why I wanted symbolic links to stay. It was the only way to make scripts under development runnable without having to constantly copy-paste.
  14. F

    Feature ASH language server features

    Because we require users to submit repositories with a directory hierarchy disposed as if they were root. This means the root of your repository CANNOT be located inside the scripts directory, as you are showing in your examples. Instead, they must, themselves, contain a scripts, data, relay...
  15. F

    Feature ASH language server features

    Here's the issue, though: if we keep the directory restrictions, it means that a single instance of the language server can only be used for a single project. However, if someone wanted to use it for more than one at a time, hard-coding a single port means that they can't... This is why I kept...
  16. F

    Feature ASH language server features

    Can it? I'm unaware of a way to connect to an already running application from the command line. (disclaimer: the next answer takes as a premise that the answer to the previous question is "no". If the answer turns out to be "yes", feel free to ignore the text below, as it invalidates the need...
  17. F

    Feature ASH language server features

    That's because language clients often seem to ask for something they can execute (pictured: IntelliJ) However, as noted in the previous post, if *they* execute the jar, then the root's location will be based on where *they* execute it, so telling them (the users) that a file isn't in the right...
  18. F

    Feature ASH language server features

    Alright, it's nearly gonna be time to start submitting the Language Server itself. Before that, though, there would be two issues (interconnected) that I have yet to solve: Communication and Path. Path These two issues start from a single point: KoLConstants.ROOT_LOCATION. public static...
  19. F

    Bug - Fixed Charpane effect decoration has a new bug.

    Could be because of https://github.com/kolmafia/kolmafia/pull/315/files . Just a quick guess before we can look further into this.
Top