Search results

  1. R

    Bug - Fixed Debug log printed with arrays containing nulls (or undefined)

    I hit this while passing a function with an invalid return -- e.g. "[1].map(x => x.key)" would output [undefined], but trying to print this on the GCLI crashes. > js null Returned: null > js undefined Returned: org.mozilla.javascript.Undefined@7fadecaf > js [null] Unexpected error...
  2. R

    New Content august scepter

    Base items / effects are in, we still need: implement the fixodent shop (and make fixodent have a "fix" quicklink instead of "use") preference for skills cast (5 / day, plus post-ronin you can cast the "today" skill once, except that it's Arizona time so if you get in close enough to rollover...
  3. R

    modifier is now a reserved word in ASH scripts

    Much like $path before it, we've added a $modifier type. This is to be used as $modifier[Meat Drop] or $modifier[Four Songs] (for example), to use in functions like numeric_modifier(item, modifier) or effect_modifier and so on. There is now also a function split_modifiers(string) that takes a...
  4. R

    New Content - Implemented Patriotic Eagle

    Lots still to do for this guy: Citizen of a Zone modifiers + parsing description (like blessing of a bird or distillate) Support for "Today" as duration (api.php treats it as a very high number, it can be SGEEA'd) Support for screech: what phylum you've banished, how long it has left, when it...
  5. R

    New Content 2002 Mr. Store

    I've added the items as skeleton, but there's still some stuff to do: * spooky vhs tape wants a 7 turn timer r27403 * loathing idol wants a command so it can be added to maximizer (well, I want this and am about to do it) r27396 * loathing idol wants to recognise that using it replaces it with...
  6. R

    Bug - Fixed Initial familiar doesn't get added to GUI dropdown types list

    When you click on your familiar in the side pane, you get a pop-up with options like "item drops" or "meat drop". Your initial familiar is not added to this list, even after you switch it out. Very noticeable in Legacy of Loathing.
  7. R

    Bug modtrace item and sidebar item drop disagree

    This is getting pretty annoying when spading! I think doubled skill bonuses (e.g. doubled from champagne) aren't being counted in the sidebar version. Can't tell why though!
  8. R

    Bug - Fixed Compact side pane doesn't include skill bonuses to meat, item, init until first status API request

    Bit of an odd one this one. When you log in, the side panel's rendition of your bonuses to meat, item, etc. don't include bonuses received from skills. "modtrace" does show these correctly, as does "ash item_drop_modifier()" and querying the item drop modifier directly. It is fixed after a...
  9. R

    Bug - Fixed Maximizer recommends unequipping weapon with Smithsness offhand

    The easiest reproduction is: @Test public void shouldntUnequipWeapon() { var cleanups = new Cleanups(withEquipped(EquipmentManager.WEAPON, "seal-clubbing club"), withEquippableItem("Half a Purse")); try (cleanups) { assertTrue(maximize("meat"))...
  10. R

    Bug - Fixed Concurrent modification exception when whitelisting to two clans in a session

    Introduced in r27086: Unexpected error, debug log printed. class java.util.ConcurrentModificationException: null java.util.ConcurrentModificationException at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013) at...
  11. R

    Feature What to do about locations / monsters with identical names?

    As came up in https://github.com/kolmafia/kolmafia/pull/1216 For items with identical names, we prefix with numbers to disambiguate, and return the one with the highest id if there's a question. For monsters and locations, we name them so that they're unambiguous (e.g. Astronomer (obsolete) /...
  12. R

    Bug - Fixed Invalid adventure area: "The Barrel Full of Barrels"

    On startup. Probably because combats.txt still has the mimics coming from there, but it isn't a location any more.
  13. R

    Bug Git scripts don't handle updating with local changes under some conditions (conflicts?)

    Sometimes, new changes fail to be applied if there are local changes. It looks like: Updating project Loathing-Associates-Scripting-Society-ChIT Pull Starting remote: Enumerating objects remote: Counting objects Receiving objects Resolving deltas Updating references Resetting head to...
  14. R

    Bug Beach access is not necessary to buy things at Uncle P's Antiques

    You can /buy things at Uncle P's Antiques without unlocking the beach. This is nice, for example, to get a turn 0 antique accordion.
  15. R

    Bug - Fixed NPE when equipping / unequipping familiar equipment to currently restricted familiar

    To reproduce: familiar none, then ash equip($item[whatever], $familiar[whatever]). Found while equipping the stillsuit at the start of a run. Unexpected error, debug log printed. class java.lang.NullPointerException: Cannot invoke...
  16. R

    New Content - Implemented The Big Book of Every Skill

    We know about the item itself, but there are a few things to add: it can be used once per day (daily pref) it is not consumed on use (don't know how we mark that) it grants a skill, and it would be nice if that skill appeared in the CLI It might be nice to have this in the optional breakfast...
  17. R

    Bug Error message for unobtainable ingredients could be improved

    > acquire imbued seal The average amount of meat spent on components (9,223,372,036,854,776,000) for one imbued seal-blubber candle exceeds autoBuyPriceLimit (50,000) You need 1 more imbued seal-blubber candle to continue. An imbued seal-blubber candle requires powdered sealbone...
  18. R

    Feature Further git installation features

    Now that I've satisfied my initial goal of being able to install ChIT and have it update reliably I'm less motivated to get things out, but there are still some things remaining I'd like to work on: showing commit messages on update adding an option, like svn, to not install dependencies...
  19. R

    You can now install scripts using git instead of svn

    Using scripts hosted on GitHub could be a poor experience as updates would fail due to GitHub's imperfect SVN support. To help with this, scripts can now be downloaded using git instead. Where you would have previously installed a script with svn checkout...
  20. R

    Bug - Fixed Found unknown equipped item: "ittah bittah hookah" descid = 279445768

    Recently, in my session logs: Found unknown equipped item: "ittah bittah hookah" descid = 279445768 I don't know why we've started not recognising the hookah (and apparently only the hookah).
Top