Search results

  1. R

    Bug Certain NPC purchasable items cannot be "acquire"d without purchasable currency

    Some shops (e.g. Toxic Chemistry, Beer Garden) are not accessible if you have no items of currency to spend at them, but the currency items themselves are tradable. In this case, attempting to "acquire" items sold at those shops fails until you gain one of the currency items. For example: >...
  2. R

    Bug - Fixed Maximizer suggests equipping a watch in the wrong slot

    My current acc1 here is the Cincho de Mayo, which doesn't offer any +adv or +fites. The Counterclockwise Watch is +3 compared to the baywatch, but it suggests replacing acc1 instead of acc3... I have reproduced this with a test, which is a rarity for maximizer bugs. @Test void...
  3. R

    New Content McHugeLarge ski set

    This has a set bonus like Brimstone that needs to be implemented (in modifiers + the maximizer). Also there are 4 skills, including one track and one NC force.
  4. R

    New Content - Implemented TakerSpace

    New workshed iotm. Make various items with ingredients that stack up over several days Wants: * command for creating items * prefs for tracking ingredients * session logging for deft pirate hook steal if it doesn't already work straight up * jolly roger flag queue manip after somebody figures...
  5. R

    Proposal: Require Java 21

    Hi all, Much like we started requiring Java 17 two years ago, we're now considering requiring Java 21 (for example, so that we can use the simd-json library for faster JSON parsing, which may help people with extremely large inventories, like me). If you're using it, you don't need to make any...
  6. R

    Bug - Fixed Mafia ignores filterfunc if pre-adventure script adventures

    Suppose we have a script that wants to adventure in the Hero's Field with a particular filterFunc -- adv1($location[Hero's Field], -1, "handle_8bit_combat") Furthermore, suppose we have a pre-adventure script that wants to ensure we have enough +item drop to maximize our points gained in the...
  7. R

    Bug - Fixed Debug log printed with arrays containing nulls (or undefined)

    I hit this while passing a function with an invalid return -- e.g. "[1].map(x => x.key)" would output [undefined], but trying to print this on the GCLI crashes. > js null Returned: null > js undefined Returned: org.mozilla.javascript.Undefined@7fadecaf > js [null] Unexpected error...
  8. R

    New Content august scepter

    Base items / effects are in, we still need: implement the fixodent shop (and make fixodent have a "fix" quicklink instead of "use") preference for skills cast (5 / day, plus post-ronin you can cast the "today" skill once, except that it's Arizona time so if you get in close enough to rollover...
  9. R

    modifier is now a reserved word in ASH scripts

    Much like $path before it, we've added a $modifier type. This is to be used as $modifier[Meat Drop] or $modifier[Four Songs] (for example), to use in functions like numeric_modifier(item, modifier) or effect_modifier and so on. There is now also a function split_modifiers(string) that takes a...
  10. R

    New Content - Implemented Patriotic Eagle

    Lots still to do for this guy: Citizen of a Zone modifiers + parsing description (like blessing of a bird or distillate) Support for "Today" as duration (api.php treats it as a very high number, it can be SGEEA'd) Support for screech: what phylum you've banished, how long it has left, when it...
  11. R

    New Content 2002 Mr. Store

    I've added the items as skeleton, but there's still some stuff to do: * spooky vhs tape wants a 7 turn timer r27403 * loathing idol wants a command so it can be added to maximizer (well, I want this and am about to do it) r27396 * loathing idol wants to recognise that using it replaces it with...
  12. R

    Bug - Fixed Initial familiar doesn't get added to GUI dropdown types list

    When you click on your familiar in the side pane, you get a pop-up with options like "item drops" or "meat drop". Your initial familiar is not added to this list, even after you switch it out. Very noticeable in Legacy of Loathing.
  13. R

    Bug modtrace item and sidebar item drop disagree

    This is getting pretty annoying when spading! I think doubled skill bonuses (e.g. doubled from champagne) aren't being counted in the sidebar version. Can't tell why though!
  14. R

    Bug - Fixed Compact side pane doesn't include skill bonuses to meat, item, init until first status API request

    Bit of an odd one this one. When you log in, the side panel's rendition of your bonuses to meat, item, etc. don't include bonuses received from skills. "modtrace" does show these correctly, as does "ash item_drop_modifier()" and querying the item drop modifier directly. It is fixed after a...
  15. R

    Bug - Fixed Maximizer recommends unequipping weapon with Smithsness offhand

    The easiest reproduction is: @Test public void shouldntUnequipWeapon() { var cleanups = new Cleanups(withEquipped(EquipmentManager.WEAPON, "seal-clubbing club"), withEquippableItem("Half a Purse")); try (cleanups) { assertTrue(maximize("meat"))...
  16. R

    Bug - Fixed Concurrent modification exception when whitelisting to two clans in a session

    Introduced in r27086: Unexpected error, debug log printed. class java.util.ConcurrentModificationException: null java.util.ConcurrentModificationException at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013) at...
  17. R

    Feature What to do about locations / monsters with identical names?

    As came up in https://github.com/kolmafia/kolmafia/pull/1216 For items with identical names, we prefix with numbers to disambiguate, and return the one with the highest id if there's a question. For monsters and locations, we name them so that they're unambiguous (e.g. Astronomer (obsolete) /...
  18. R

    Bug - Fixed Invalid adventure area: "The Barrel Full of Barrels"

    On startup. Probably because combats.txt still has the mimics coming from there, but it isn't a location any more.
  19. R

    Bug Git scripts don't handle updating with local changes under some conditions (conflicts?)

    Sometimes, new changes fail to be applied if there are local changes. It looks like: Updating project Loathing-Associates-Scripting-Society-ChIT Pull Starting remote: Enumerating objects remote: Counting objects Receiving objects Resolving deltas Updating references Resetting head to...
  20. R

    Bug Beach access is not necessary to buy things at Uncle P's Antiques

    You can /buy things at Uncle P's Antiques without unlocking the beach. This is nice, for example, to get a turn 0 antique accordion.
Back
Top