Search results

Hm. Looks like the text was added on Feb 25 (https://kol.coldfront.net/thekolwiki/index.php?title=Combat_Frequency&diff=710087&oldid=706197) but I cannot find any references to a change happening around that time. As for the original request, you're entirely correct that min / max aren't really...

When was this introduced? I don't remember this cap existing in the distant past, and I don't see any references to it in announcements / trivial updates or on the wiki.

Yeah, there's another PR that @Ryo_Sangnoir crafted a few hours ago which should fix it... probably r28159 in a few minutes.

Anyways, try again with r28158? There were some KoL changes as ckb pointed out.

Per https://kolmafia.us/threads/buffer-to_buffer-string.29161/#post-173126, the to_buffer(string) message is a warning but does not cause scripts to break.

I don't have the cape, either. That logic is run unconditionally. I suspect the actual trigger is tied to having specific passive skills. (Expert Panhandling was an obvious guess given the relevance of the saucepan, but it seems that is insufficient and potentially irrelevant.) I have not yet...

Okay. So the sequence of events starts out: "equip knob goblin scimitar" triggers the removal of a bunch of retro superhero cape skills (which registers a deferred listener to refresh the passive skill cache the next time we want to fetch adjustments)...

I've shrunk the second reproducing test case to: ash print(inebriety_limit()); equip Knob Goblin scimitar; ash print(inebriety_limit()); outfit birthday suit; ash print(inebriety_limit()); equip saucepan; ash print(inebriety_limit()); which I've saved in a file called reproducer.txt. From my...

Should be fixed as of r28141. Do let us know (on... Feb 19?) if you experience it again.

I assumed that this issue has existed since we changed organ capacity to be tracked as proper modifiers (r27601), which was committed on the date frono identified. A cursory glance at the code confirms that's the case (typo in modifiers.txt, previous code in KoLCharacter.java referring directly...

https://github.com/openjdk/jdk21u-dev/pull/1020 is the backport to Java 21, FYI. I'd like to hear more about how it's not working for you, since AFAIK it's not causing problems for our Windows test executions on Github.

Event Feast of Boris Stomach Capacity: [min(1,path(none)+path(Teetotaller))*(1-class(AWOL))*15] Looks like someone misspelled "Teetotaler".

For what it's worth, I don't think the GOAWAY fix has been backported to Java 21 yet. I think Java 22 might have it, 23 definitely does.

As others have mentioned, you need at least Java 17 to build and run Mafia. We are planning to bump that minimum version to Java 21 (the latest long-term support release) in the near future (next month or two, I'd guess), so it may make sense to get ahead of the curve. To the best of my...

I suspect that may be the case -- it sounds like we need to make a clear distinction between JS that runs in the browser, as opposed to JS that runs in Mafia's Rhino engine to execute various actions including generating assets served by the relay server (which is what most mentions of "JS" as a...

This should be fixed with r28100.

I will defer to @Veracity here, but I'll try to address some of the comments / questions. I expected both of you would have received an alert when I mentioned both of you directly in #3. https://kolmafia.us/account/preferences has an option for receiving notifications (via the bell icon in the...

https://github.com/kolmafia/kolmafia/pull/2482 seems to fix the problem on my end.

I can reproduce readily. A manual bisect indicates that this broke as a result of r28091, which finished replacing the json library that we use. @ikzann We may want to revert the change if we can't figure out a fix-forward.

Specifically, I mention the passive skill cache because recalculateAdjustments(true, ...) creates a new DebugModifiers which in turn, among other things, forcibly refreshes the passive skill cache.