Search results

In my script, I typically have `relay nobrowser` as one of the lines so that it spawns up the relay server (without explicitly launching the relay browser), and if it gets stuck I can just open 127.0.0.1:60080/game.php to click on some buttons or execute some /cli commands in chat (which then...

Can confirm -- I see the charpane now says level 255 for a character with max stats. Which, I don't think anyone really cares about that distinction, although it makes certain scaling (e.g. MMJ) marginally worse. I'm happy to have consistency, either way.

For a number of years, I fully automated Mafia for several characters in an AWS VM, so yes, this is absolutely possible without any modifications. The easiest way to do this is to run something like `java -jar KoLmafia-*.jar -Djava.awt.headless=true --CLI some_script.txt` where some_script.txt...

Yep, that's exactly the problem. https://github.com/kolmafia/multitool/blob/main/src/us/kolmafia/multitool/Multitool.java#L186 This is essentially backsliding from attempting to solve https://kolmafia.us/threads/multitool-an-implementation-and-feature-discussion.30272/page-2#post-176348 -- you...

`C:/Program` sounds like we're trying to run something in C:/Program Files/ and running into a problem because of the space in the directory name.

Hm. It seems that to date, there are no skills granted by equipment that can be used both in-combat and out-of-combat. In fact, the list of combat skills with other purposes is quite small, and hasn't been expanded in over ten years: $ grep -E 'combat,|,combat' data/classskills.txt 3009...

Short-term fix, try removing (or otherwise relocating) your existing Mafia jars. Multitool tries to find all KoLmafia-*.jar and derive the corresponding revisions; this interacts poorly with other autodownloaders such as KoLMafiaUpdate.exe which copy the latest jar to a file called...

I have not given adequate thought to that PR in over a year. I saw Rinn's fix, and I think it's a very plausible explanation. I would be happier if we had better tooling to ensure that all reads / writes were properly synchronized.

Thanks! I suppose there's still a secondary bug where we flip back and forth between two values due to KoL reporting an incorrect level in api.php. We're also still not detecting level from charpane.php for the titles that embed %L and don't actually mention the word "level", although I am not...

Of course, the character I'm testing with doesn't have charpane.php with the default UI detect the level (custom title or not), since we apparently only handle the cases of compact charpane and regular charpane with a custom title that doesn't contain %L (where the level renders after the title...

Ah, yes, r28372 would have done it -- logged into a char with max stats, and api.php shows level 255. Meanwhile r28391 is fighting with it every time charpane.php is loaded, which detects the level as 256, but the next load of api.php resets the level back to 255 again.

No, the max level has been 256 for some time. I suspect that the new logic re: level parsing in r28391 broke this. edit: or possibly r28372.

Ha. Yes, there are lots of advantages, like for instance durability (and the rest of the ACID properties). The main "disadvantage" is that it is less human-editable. Perhaps the biggest thing stopping us from adopting this is migration cost. I had previously attempted to start a discussion on...

Both can be true! Note that the code returned early if you were running a daily build (`KoLConstants.VERSION_NAME.startsWith( "KoLmafia r" )`). https://github.com/kolmafia/kolmafia/blob/a0b5d8ad4d0657a4f8e151152b50fbdf31060bee/src/net/sourceforge/kolmafia/KoLmafia.java#L2152 Incidentally, the...

I believe it dates back to the days of point releases (which we differentiated from the daily builds via "version" vs "revision"). If there was a newer point release than what you were running, Mafia would create a popup recommending that you update. As I'm sure you recall, some segment of our...

Mafia currently thinks your mainstat is muscle. My guess is that KoL is treating your mainstat as the max of the three, similar to Plumber or Grey Goo, but we need different special handling for determining your level in this path.

The error that I ran into (and which I assume fewyn ran into) was in a script that essentially invoked sell_price($item[cyburger].seller, $item[cyburger]). sells_item unfortunately does not help here, although I think you're spot on with your observation of coinmasters with multiple costs.

I'm inclined to agree, although maybe for slightly different reasons. One, I think JSON is overkill for what we need. Two, I would prefer to keep our external dependencies to a minimum. log4j in particular burned the entire industry quite badly a few years back, so I'm starting from a point of...

Thanks @Ryo_Sangnoir for r28355 (adapting my patch from #4), which should at least stop the NPEs until we have time to investigate further what the desired behavior should be.

My somewhat hacky workaround without fully understanding why CoinmasterData.token is null is to add null checks in isHP() and isMP(). (And for completeness, the other similar methods that dereference a string without checking if it's null first). diff --git...