Search results

  1. H

    Is this possible for ccs - use fury skill only at maxfury

    That said, from staring at Mafia's code, it seems that it'll execute top-level code as you've written, and if it can't find the main function, then it'll silently exit. So you're probably running into the point that frono raised. (I've also run a few turns and confirmed that your script as...
  2. H

    Is this possible for ccs - use fury skill only at maxfury

    You probably want to wrap this in a special main function, as in https://wiki.kolmafia.us/index.php/Custom_Combat_Script#Consult_Scripts: void main(int initround, monster foe, string page) { if (my_fury() == my_maxfury()) { use_skill($skill[Furious Wallop]); } } Further, as fronobulax...
  3. H

    Bug You are too drunk to continue

    (https://github.com/kolmafia/kolmafia/pull/2335 should address this when it gets merged)
  4. H

    Bug You are too drunk to continue

    Hm. Mafia probably doesn't think that the skill does anything because you're in G-Lover, and "Liver of Steel" does not contain any G's. According to the wiki, that's actually incorrect, as passives seem to work as usual.
  5. H

    Bug - Fixed Mafia Auto Updater Broken

    Also, technically this isn't a Mafia bug so much as a change in infrastructure combined with a third-party tool relying on an unstable implicit API, namely the HTML formatting of the current version of Jenkins. (If I felt strongly enough, I'd move this thread to the Community Support section, or...
  6. H

    Bug - Fixed Mafia Auto Updater Broken

    FYI -- as of yesterday (after this discussion), it looks like the owner of that repository updated to fetch from github directly. So, update and I think you should be good. https://github.com/sapph42/KoLMafia-Launcher/commit/3b8d8f341e8cdd5939ee60503feface783f67b99
  7. H

    Bug Max Drunkenness drops when equipping weapon/off-hand

    `modtrace` is a bit of a hack, in that it will "fix" things short term but does not help us get much closer to figuring out what's going on. But it does seem like it confirms that it's (likely) the passive skill cache at fault if that fixes the problem, since that's one of the unique things that...
  8. H

    Bug You are too drunk to continue

    r27940 may address the ronin-break and king liberation scenarios, although I have only verified this in synthetic tests, not by actually ascending and breaking ronin or freeing the king. There seem to be other scenarios where this happens (including whatever ckb's been experiencing), so I don't...
  9. H

    Bug Max Drunkenness drops when equipping weapon/off-hand

    This is very surprising, and runs counter to my current understanding of the problem. Exactly what steps are you taking to log off & back on? The short version is that we calculate all the modifiers associated with passive skills and store those values so we don't have to keep recomputing them...
  10. H

    Bug You are too drunk to continue

    Ronin-break at least does not seem to trigger any modifier adjustment, which is a bug if true. I assumed that king liberation is a race condition.
  11. H

    Bug You are too drunk to continue

    These are useful data points. I'll try to get some time later this week to look at specifically the king-liberated and ronin-break handling. (Specifically: it sounds like ronin-break means that one of your permed skills starts having effect again? Drinking to Drink, probably?) In the meanwhile...
  12. H

    Excavator - gausie's spading script

    Github Actions compile that into JS on the `release` branch after each commit that's pushed to `main`. https://github.com/loathers/excavator/blob/main/.github/workflows/deploy_script.yml If you want to compile this yourself, you'll have to install one of the various TS -> JS transpilers...
  13. H

    Feature Request: Discuss Retry-After header in Generic Request

    > 503/429 messages, since that mechanism is designed to cover cases of scheduled maintenance with a known end-period Incidentally, that's not how I view either of those status codes. 429 ("Too many requests") serves a purpose directly related to Retry-After in terms of throttling, and it seems...
  14. H

    Bug You are too drunk to continue

    If "modtrace liver" does nothing, then that's a distinct problem (namely: unrelated to the modifier passive skill cache). From looking at the commit: visiting the wereprofessor research bench to look at your current upgrades should update your preferences appropriately. If that's not happening...
  15. H

    Forum help and cleanup

    To clarify: previously both "feature" and "feature - implemented" were the same shade of light green. The current status is a strict improvement over that.
  16. H

    Bug - Not A Bug r27822 Unwanted password dialog box pops up with Chrome + KoLmafia

    Closing with "Not a bug" since it was apparently a Chrome bug. Either way, it's unlikely we can do anything about it on Mafia's end if it comes back.
  17. H

    Forum help and cleanup

    I think it makes sense to differentiate between Feature and "Feature - Implemented" / "Bug Fixed", at the very least. So no objections from me re: new colors.
  18. H

    New Content Feb 2024 Challenge Path - Were Professor

    r27837 fixes the debug log that Boesbert reported.
  19. H

    New Content Feb 2024 Challenge Path - Were Professor

    Hm. That last one is a different stack trace, where AscensionClass might never be initialized (and therefore is still null if there are no matches). It's an easy fix; I'll post a pull request in a bit.
  20. H

    "Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0."

    I don't see any logical issues with adding `shadowJar.mustRunAfter cleanDist`, which is the other option that Gradle suggests -- it doesn't make sense IMO to clean after building the jar, after all.
Back
Top