Search results

Put simply, yes. The best way to help us figure out this problem is to help us figure out how to reproduce the problem consistently. In particular, if you have some setup that consistently triggers the bug across multiple characters with differing sets of skills, available items, ascension...

A possibly terrible idea I had when starting to read this post: what if we generalized this such that if you import a script with a conflicting function func (or, generally, any symbol), it's only imported as func@script? And otherwise (for backwards compatibility purposes), all other functions...

Perhaps we should be checking InventoryManager.getAccessibleCount(TOXIC_GLOBULE) == 0, since in order to purchase anything from that coinmaster, you need toxic globules, which trivially satisfies the accessibility requirement.

There is some bifurcation of logic between whether you're running this in headless mode or not. Preferences.java#L183-198: if (SwinglessUIUtils.isSwingAvailable()) { try { SwingUtilities.invokeLater( () -> {...

As in, the vast majority of our users who just download the jar and double-click on it to launch Mafia?

I omitted a few steps in my reasoning. I was wondering if there were any situations where we would want to remove a skill for combat purposes (where we obviously cannot just change equipment) but keep it for noncombat purposes. It seems the answer, at least for now, is "no".

Yeah, the second error is because Java is in a directory with a space in the name (which primarily affects Windows users, who usually have Java under C:\Program Files\). Known issue; we'll provide an update when that's fixed.

I am surprised by the notion that multitool might download a new jar, and then not launch it. Would it launch the old jar? Would it do nothing? IMO the "expected" behavior from what I am viewing as a launcher + auto-updater is the following steps: Update Mafia if necessary. Clean up old...

Observation before you go too far down that path: Record didn't come until what, Java 15? (okay, looks like first preview was Java 14 and it was finalized in 16.) You're correct that the right answer is generally "before refactoring" to prevent further backsliding :) Regarding the reported...

In my script, I typically have `relay nobrowser` as one of the lines so that it spawns up the relay server (without explicitly launching the relay browser), and if it gets stuck I can just open 127.0.0.1:60080/game.php to click on some buttons or execute some /cli commands in chat (which then...

Can confirm -- I see the charpane now says level 255 for a character with max stats. Which, I don't think anyone really cares about that distinction, although it makes certain scaling (e.g. MMJ) marginally worse. I'm happy to have consistency, either way.

For a number of years, I fully automated Mafia for several characters in an AWS VM, so yes, this is absolutely possible without any modifications. The easiest way to do this is to run something like `java -jar KoLmafia-*.jar -Djava.awt.headless=true --CLI some_script.txt` where some_script.txt...

Yep, that's exactly the problem. https://github.com/kolmafia/multitool/blob/main/src/us/kolmafia/multitool/Multitool.java#L186 This is essentially backsliding from attempting to solve https://kolmafia.us/threads/multitool-an-implementation-and-feature-discussion.30272/page-2#post-176348 -- you...

`C:/Program` sounds like we're trying to run something in C:/Program Files/ and running into a problem because of the space in the directory name.

Hm. It seems that to date, there are no skills granted by equipment that can be used both in-combat and out-of-combat. In fact, the list of combat skills with other purposes is quite small, and hasn't been expanded in over ten years: $ grep -E 'combat,|,combat' data/classskills.txt 3009...

Short-term fix, try removing (or otherwise relocating) your existing Mafia jars. Multitool tries to find all KoLmafia-*.jar and derive the corresponding revisions; this interacts poorly with other autodownloaders such as KoLMafiaUpdate.exe which copy the latest jar to a file called...

I have not given adequate thought to that PR in over a year. I saw Rinn's fix, and I think it's a very plausible explanation. I would be happier if we had better tooling to ensure that all reads / writes were properly synchronized.

Thanks! I suppose there's still a secondary bug where we flip back and forth between two values due to KoL reporting an incorrect level in api.php. We're also still not detecting level from charpane.php for the titles that embed %L and don't actually mention the word "level", although I am not...

Of course, the character I'm testing with doesn't have charpane.php with the default UI detect the level (custom title or not), since we apparently only handle the cases of compact charpane and regular charpane with a custom title that doesn't contain %L (where the level renders after the title...

Ah, yes, r28372 would have done it -- logged into a char with max stats, and api.php shows level 255. Meanwhile r28391 is fighting with it every time charpane.php is loaded, which detects the level as 256, but the next load of api.php resets the level back to 255 again.