Search results

Wait, if we're absolutely certain that pickpocketing will yield no item, why would we want to try? Why would anyone want to try?

I like the idea, sorta. Dunno about calling it "smart" pick pocketing, because some people may not consider the current behaviour to be "smart" and it sounds vague. I think there should be a way to enable KoLmafia to attempt a pick pocket if it's not known that an item can't be pick pocketed...

The KoLconstants is a different beast, I can't just fix the type safety or it causes a compile error, so yes it needs to be reworked, as well as a few other classes (eg. some of the SortedLists for AdventureResults, and another class used by the maximizer that I can't remember at the moment)...

*

*

I'll post the attachments to some of the type safety and variable/class visibility changes here. I'm keeping the patches for each .java file separate, so whoever decides to review them please let me know which ones you have committed and I'll remove the associated attachments to help keep track...

Add seconds to the chat log, leave the chat window how it is?

I'm not sure what metrics Java uses to determine which stack to use, but it will always prever IPv4 if you have preferIPv4Stack set to true and IPv4 is available, it won't necessarily go to IPv6 if you have both enabled. Try launching the JAR with the command line options...

I believe this may be relevant.

Is that you had to patch xmonad or KoLmafia? Was it a generic fix or something specialized? I think I vagueley remember that, I don't think it was happening for me. Wasn't it to do with the Nimbus LAF? I'm not sure what version the jdesktop libaries are, but there's possibly some fixes we can...

Most of you all know that Java 6 is the official recommended version of Java to be used with KoLmafia. Some of you may not know, however, that Java 6 officially goes EOL in February 2013, just 2 months away! What this means is Oracle will no longer be providing security fixes for Java 6 after...

This will likely affect the SSH scripts I'm using to upload the JET nightlies, but I'm sure the JET users wouldn't lose too much sleep over not having an updated build for a day or two if there were any unforeseen issues with me simply changing the upload path. Also, I agree with Bale's...

The skill shouldn't even be in options if it has been used 5 times. AFAIK, you can only use it once per combat but up to 5 times a day. Tracking how many times it has been used in a day is pretty irrelevant, because BatBrain should be removing it from options if it doesn't appear in the skill...

I posted about it here. The issue is actually with BatBrain not removing unavailable skills from options. I haven't put my finger on where the issue lies yet, but what I posted here should at least stop WHAM from infinite looping, at the expense of possibly other skills not being considered (I...

It's generally considered good practice to declare your functions in the code before using them though, even if the interpreter doesn't care. The same is true for imports, even though you could theoretically put them anywhere within the global context.

Correct. I must admit I wasn't understanding what the code was doing properly, I didn't realize BatBrain was actually looping through every known skill in the database. In theory, what you would expect though is that if I had that break there, combat would stop entirely because the for loop is...

Probably not. I don't think I posted the correct fix, but what I can tell you is that prior to making that change, WHAM was considering skills I couldn't use. I think the conditional logic is messed up somewhere there, I tried a few different things and made edits to the post but in the end...

I'm not really sure how unconventional and difficult to maintain code can be at the same time considered "smooth", but if you say so. Reading zarqon's code, for me, is like reading code written by my boss: a good idea for the business that hasn't been thought of before, written in spare time...

When checking suitability of skill consideration, it actually parses fight.php for unavailable skills and it doesn't break if it finds that the skill is unavailable... It doesn't work at all. I changed: if (skillsbit == "" ? !have_skill(to_skill(sk)) ...