Search results

  1. R

    Bug - Fixed Javascript toJson leaves object keys in underscore_format rather than camelCase

    Given > js toJson({"underscore_thing": "other_thing"}) Returned: {"underscore_thing":"other_thing"} I think this is going to be a bit annoying to fix: you want it so that if you pass in a proxy record, the keys are transformed similarly to the way the JavascriptRuntime transforms the keys...
  2. R

    Feature Collect Untradable Pulls

    Sure, can do. How do you want the list to work? You've said the Shore shouldn't appear unless you have adventures / meat (and aren't overdrunk, I guess). For the cookbookbat foods, you want them to not appear if you don't know the recipes? For item availability, currently it buys the ingredients...
  3. R

    Feature Functions as first-class objects in ASH

    All the functions coincidentally take two parameters, but I assume that's not necessary ;) A useful function can take any number of parameters, including zero. A motivating use-case for JavaScript at the moment is chaining filter, sort, map on arrays for quick CLI queries. An example is: js...
  4. R

    Bug Offhand remarkable is incorrectly applying to weapons equipped in offhand

    Thanks for the report, should be fixed in r27552.
  5. R

    buffer to_buffer(string)

    I think that's a great idea! The other thing to decide is whether it should call the one you've defined or the inbuilt one: I think it should call the one you defined. This will let scripts keep working as they expect. Path was a bit different as I recall: there, the issue was that lots of...
  6. R

    Bug - Fixed Using mall_price doesn't ignore forbiddenStores

    I'm not sure it's worth spending much effort stopping people from mallbotting any more -- those inclined are almost surely compiling their own version of Mafia that strips out the various checks. A decent number of people are compiling their own Mafia for reasons completely unrelated to...
  7. R

    Bug Maximizer Bug

    What if you run it without "13 max"? My thought here is that the initial outfit already reaches the maximum, so it might be discarding all the familiar experience it can see, which lowers it below the limit.
  8. R

    Bug - Cannot Reproduce Maximizer quirks - "-combat" and melee vs ranged.

    Can't reproduce, sorry. // https://kolmafia.us/threads/maximizer-quirks-combat-and-melee-vs-ranged.29104 @Test public void shouldNotDowngradeBetterOutfitNonCombat() { var cleanups = new Cleanups(withClass(AscensionClass.SEAL_CLUBBER), withFamiliar(FamiliarPool.DISGEIST, 100)...
  9. R

    Bug Maximizer Bug

    Yeah, but the first step to fixing this is to make a failing unit test, and I can't do that if I don't understand what's going on. I've also had it flipping between better / worse, but not to this extent.
  10. R

    Bug Maximizer Bug

    This modtrace looks very odd to me. It's saying that giant discarded bottlecap gives +3 Fam Exp, portable corkscrew gives +2, makeshift cape gives +1... that isn't right? mummy mask doesn't give any either? Is this in TCRS? Edit: Looks to be TCRS AT Vole.
  11. R

    Bug - Cannot Reproduce Maximizer quirks - "-combat" and melee vs ranged.

    What class are you? What weight is your Disgeist? I assume you don't have fuzzy slippers of hatred, because they aren't equipped?
  12. R

    New Content august scepter

    Base items / effects are in, we still need: implement the fixodent shop (and make fixodent have a "fix" quicklink instead of "use") preference for skills cast (5 / day, plus post-ronin you can cast the "today" skill once, except that it's Arizona time so if you get in close enough to rollover...
  13. R

    r26152 - BasicScope obsolete comments by @fredg1 in

    The other pop-up window you wind up seeing a lot is Degrassi Knoll shopping list: if you have philter set up to deal with items, then each ascension the first run will throw away the shopping list, and you'll get another window. Personally, I don't care for the window popping up (both because...
  14. R

    r26152 - BasicScope obsolete comments by @fredg1 in

    Making blood-faced volleyballs was pretty common while the diabolic pizza cube was in Standard -- if you made a pizza with a familiar, you got familiar equipment for your current familiar. This was a good way to get the Pocket Professor equipment for +2 lectures. Also blood-faced volleyball is...
  15. R

    New Content Perpetrate Mild Evil

    There's probably multiple messages I'm not matching. Add them to the wiki! Or file a PR.
  16. R

    Bug - Fixed Git projects outside of github are not named correctly

    Fixed by just resolving it from path. r27486.
  17. R

    Bug - Fixed screechCombats does not reset on ascension

    Yeah, it needs adding to the big resetOnAscension array in preferences/Preferences.java. This is easy to forget and I often do.
  18. R

    Error on running "git update" (and on mafia start)

    No, it's fine to start with a dot. But it should be iterating over folders, instead of files and folders.
  19. R

    Bug - Fixed Git projects outside of github are not named correctly

    We could just make an identifier for other sites using the same logic we do for github. When I wrote that in the first place, I assumed that if other sites became popular hosts, I could add proper support for them then. Given that this is the first report, over a year since git support was...
Back
Top