Search results

Thanks. I added a test using your html. Ryo already merged my previous commit - which fixed both the FIreworks Shop and the Mayo Clinic - so I have a new PR with nothing but a test for the Mayo Clinic. I may just merge that one myself. :)

With my (currently open for review) PR: > set _fireworksShop=false _fireworksShop => false > set _fireworksShopEquipmentBought=false > set _fireworksShopHatBought=false _fireworksShopHatBought => false > ashq visit_url("clan_viplounge.php?action=fwshop&whichfloor=2") Visiting Underground...

I see that both fwshop and mayoclinic need to examine the responseText for simple visits. I have an aftercore character with access to the Fireworks Shop, so I was able to write a test. I have an open PR which fixes the issue. https://github.com/kolmafia/kolmafia/pull/2713

OK. I can see the issue. For NPC shops, we are no longer parsing the response unless you are actually buying something. I would not be surprised is that is the issue with the Fireworks Shop, too. I'll fix that.

I assume this is a bug in the FactDatabase.getFact(), but I am now fighting a medusa and I see "Fact: 10". > ash $monster[medusa].fact_type Returned: hp > ash $monster[medusa].fact Returned: 10

OK. I should be able to test that. My aftercore character with access to the fireworks shop bought a hat, not an accessory, so it should still be available.

The Underground Fireworks Shop is an NPC store, not a coinmaster. 1) With a character in a clan with that shop, if I do a Mall Search for "fedora", I see a fedora-mounted-fountain available from that shop for (1 @475). I.e., limited to 1 and not greyed out. > acquire fedora-mounted fountain...

Here is test_fight_cupid_heart_necklace.html.txt I do not understand why I could not upload the .html file. I used a golden pet rock because I am in run and that is Standard compliant.

This is why you are a Minion: you track existing bug reports and coagulate them when they are similar issues. Thank you! I am in-run - and also working on a major complicated PR - but I'll look at all of these, soonish.

We try to set zone for item generated monsters to none. This is probably a mafia bug, but I will have to look later. Thanks!

What the heck? Did you verify that garbo ran only 10 adventures in the zone today? You logging showed something about "relayCounters changed from 1264:Digitize Monster loc=* type=wander:watch.gif to 1271:Digitize Monster loc=* type=wander:watch.gif". Did garbo attempt to digitize monsters for...

I assume it would use priceToMake, which returns the lowest of crafting vs. mallbuying. Note that this, also depends on valueOfInventory, since it assumes you'll want to use items you already own. Fun fact: that is mutually recursive with priceToAcquire - priceToAcquire calls cheaperToBuy with...

That is exactly what it is telling you. "The cheapest way you can acquire" an item is to use one you already have; that's how retrieve_item() works. Now, if you want to acquire two, but only have one, retrieve_item() will decide whether to buy or create the second. Since you told retrieve_item...

This is not the "cost to create". If that is your "expectation", perhaps you should reconsider how you are using it. retrieve_price (aka priceToAcquire) is used by priceToMake is used by cheaperToBuy is used by retrieve_item. That last function (aka "acquire") only considers buying or making if...

I finally did my test. Manually adventured for 10 times. It used 10 free turns and left _cuberZone1Turns at 10. Automated via GUI for 19. It used 10 turns and collected the prize and stopped automation with "That area is not available" when attempting the 11th. Which is exactly what I expected...

No problem. Glad it's working correctly for you!

OK, that all looks good. You SHOULD be able to auto-adventure via the GUI in zone 1 for 10 and it will stop without aborting and _cyberZone1Turns will be 20. I don't use garbo, but I will try manually adventuring in zone 1 until I get the NC and will then adventure via the GUI and see how it...

OK. Here is the check for canAdventure() in a cyber zone: if (this.zone.equals("Server Room")) { if (Preferences.getBoolean("crAlways") || Preferences.getBoolean("_crToday")) { String property = switch (this.adventureNumber) { case...

I love this script. KoL broke it with their changes earlier this year. Fix: diff --git a/relay/place.8bit.js b/relay/place.8bit.js index 2931ec9..afc72a8 100644 --- a/relay/place.8bit.js +++ b/relay/place.8bit.js @@ -6,7 +6,7 @@ module.exports.main = () => { var pageText = visitUrl()...

With Overclocked, the first 10 adventures are free. Until/unless KoL fixes its bug, the (already free) half-way NC will use one of those. After that, the next adventure - the first after the NC - will be the first to use a turn. The next 9 - including the final NC - will also use a turn. My...