Search results

Thank you. For what it's worth, I used the term "rebase" because SVNManager.java has a function named getRebase(). It is totally unrelated to rebasing in SVN, and I don't think KoLmafia does a SVN rebase. It just borrowed the terminology. I hope it didn't confuse you too much.

Welcome to the club! A button with nothing but [x] isn't too intuitive IMO. Maybe prepending a ❌ or ⚠️ to the button text might be better. Edit: The forum software replaces emojis with images. I believe the HTML entity is ❌ and ⚠

We did find a name collision problem in the wild between Cargo Shorts UI and Philter. It was due to both scripts providing an index.html in two different directories. These files were not trying to override the same page; they were completely unrelated files, with the unfortunate coincidence of...

Uh, sure. I don't have an opinion on this, and it probably won't affect me very much. JS authors never had name collision troubles at run time because we always use relative paths to import other JS scripts, or because we bundle our code into one big script which imports nothing. Is there a...

I'm treading unfamiliar territory; gausie and bean would be the right people to consult with. But I believe KoLmafia's JavaScript runtime uses different logic for importing ASH and JS. When importing an ASH script it uses findScriptFile() in the code you saw. I can call require("somefile.ash")...

I set up a breakpoint in SVNManager.java to trace the code step by step while installing and updating a project with gCLI commands. That code calls findScriptFile() for every file that is "created" in the working copy. Not just ASH, but also CSS, TXT, and HTML. Edit: See...

For what it's worth, KoLmafia as of right now allows the following scenario to happen: User installs Project A, which has: relay/ one/ foo.txt bar.txt User edits foo.txt Project A's developer deletes foo.txt. Git records this as a file deletion since relay/one/bar.txt still...

When we forked OCD Inventory Control we retained the behavior of asking once on each invocation. I can't recall there being a setting, so it's possible that you manually edited the ASH code to comment out the popup code. No promises, but I'll see if I can add a setting that suppresses the popup.

Right now, both Managers show uncategorized items in your inventory, though we also display their quantities in the closet, DC, and Hagnk's--check out the "C", "S", and "D" columns in the item tables. Clan stash is not included, which is probably a good thing since other people can add items...

For anyone hit by the issue described in reply #32, I fixed the issue on OCD-Cleanup's end. You can install it and Cargo Shorts together without worries.

Moving the discussion here. I hope we can work things out despite our misunderstandings. This is not a JavaScript problem. I can build two relay scripts written in ASH that would suffer from the file name collision problem--not just ASH files, but also CSS or font files with the same name...

It looks like this project is beset by the behavior that overwrites identically-named files. If you install Cargo Shorts GUI and the recent version of OCD-Cleanup (in whatever order), index.html from one project would overwrite the other, despite being placed under separate subdirectories. This...

Thank you for describing the crux in a way that I never could. And yes, the issue was with the local copy, which is managed directly by KoLmafia rather than Subversion. Whenever I moved a directory or renamed a file in the GitHub repo, svn update faithfully reflected these changes in the working...

I have no control over how GitHub's subversion compatibility layer translates a directory rename operation into a "delete directory" operation. The truth is I've been struggling for a workaround for the last two weeks without luck. I want to make svn update rename a subdirectory on the local...

I just updated my KoLmafia to r20731 and my passwords and preferences were still there. Did you try launching the version of KoLmafia you were using before r20731? Did you check the settings/ directory? We can debug problems better if you give us more info :)

Sure. As long as I can continue to import ZLib and other libraries. I am probably underqualified to talk since I rarely use the Script Menu these days. I just type in the name of the script to call it. But a Bookmark system--similar to what web browsers provide these days--would provide enough...

Here's a patch that disables the "smart lookup" (i.e. rebasing) for relay/. The reasoning being that relay scripts generally expect a strict directory layout, and users will never move around files in there. (For example, if your relay script uses relay/my-dir/styles.css, you can't move it to...

Incidentally, I think I know why we are using LIFO (stack) instead of FIFO (queue). It's a hack. When scripts/foo/a.txt is moved to scripts/bar/a.txt, SVN interprets it as a "create scripts/bar/a.txt" + "delete scripts/foo/a.txt", in that order. If we used FIFO, KoLmafia would do this...

I think I narrowed the root causes of the "failed to rename" problem described in the first post. I say "causes" because it is actually two problems in one: svn update overwrites existing files. svn update does not delete non-empty directories. Here is my testing process: I created a...

@fronobulax Fair enough. I admit that throwing ASH scripts inside relay/ is a hacky way of discouraging users from trying to run or import them directly. That said, I would still like my HTML, CSS, and JS files to be protected by being placed inside a uniquely named subdirectory. I don't want...