Search results

It looks like it doesn't properly set the skills while initially setting session data (in refreshSessionData in KoLmafia.java). However, this doesn't make any sense to me -- because at the top of the function it calls GenericRequest request = new CharSheetRequest()...

Probably something to do with the order things run in. The same problem occurs with the daily deeds for free rests. I guess something needs to prompt it to update after the first recalculateAdjustments of the session. Or we extract the static initializer from modifiers and move it to the main...

Fixed as of r27608. Thanks for the report!

27601 switched to reading liver from modifiers instead of a custom method, but Hollow Leg is a passive skill so I don't understand why this isn't working.

They couldn't be copied during Crimbo, but they were marked as copiable after Crimbo. They can't be fought using Genie wishes because they have an "executeonwin" function. You can Rain Man them if you have factoids, and they're faxable.

I hit this while passing a function with an invalid return -- e.g. "[1].map(x => x.key)" would output [undefined], but trying to print this on the GCLI crashes. > js null Returned: null > js undefined Returned: org.mozilla.javascript.Undefined@7fadecaf > js [null] Unexpected error...

Nice find! It would need to be added to src/data/monsters.txt I'll PFC the rate tomorrow.

Try: ash numeric_modifier("Zone:Shadow Rift", $modifier[Item Drop]) You could also set_location($location[none]); to avoid the zone modifier entirely.

Given > js toJson({"underscore_thing": "other_thing"}) Returned: {"underscore_thing":"other_thing"} I think this is going to be a bit annoying to fix: you want it so that if you pass in a proxy record, the keys are transformed similarly to the way the JavascriptRuntime transforms the keys...

Sure, can do. How do you want the list to work? You've said the Shore shouldn't appear unless you have adventures / meat (and aren't overdrunk, I guess). For the cookbookbat foods, you want them to not appear if you don't know the recipes? For item availability, currently it buys the ingredients...

r27559

All the functions coincidentally take two parameters, but I assume that's not necessary ;) A useful function can take any number of parameters, including zero. A motivating use-case for JavaScript at the moment is chaining filter, sort, map on arrays for quick CLI queries. An example is: js...

Thanks for the report, should be fixed in r27552.

I think that's a great idea! The other thing to decide is whether it should call the one you've defined or the inbuilt one: I think it should call the one you defined. This will let scripts keep working as they expect. Path was a bit different as I recall: there, the issue was that lots of...

I'm not sure it's worth spending much effort stopping people from mallbotting any more -- those inclined are almost surely compiling their own version of Mafia that strips out the various checks. A decent number of people are compiling their own Mafia for reasons completely unrelated to...

What if you run it without "13 max"? My thought here is that the initial outfit already reaches the maximum, so it might be discarding all the familiar experience it can see, which lowers it below the limit.

Can't reproduce, sorry. // https://kolmafia.us/threads/maximizer-quirks-combat-and-melee-vs-ranged.29104 @Test public void shouldNotDowngradeBetterOutfitNonCombat() { var cleanups = new Cleanups(withClass(AscensionClass.SEAL_CLUBBER), withFamiliar(FamiliarPool.DISGEIST, 100)...

Yeah, but the first step to fixing this is to make a failing unit test, and I can't do that if I don't understand what's going on. I've also had it flipping between better / worse, but not to this extent.

This modtrace looks very odd to me. It's saying that giant discarded bottlecap gives +3 Fam Exp, portable corkscrew gives +2, makeshift cape gives +1... that isn't right? mummy mask doesn't give any either? Is this in TCRS? Edit: Looks to be TCRS AT Vole.

What class are you? What weight is your Disgeist? I assume you don't have fuzzy slippers of hatred, because they aren't equipped?