Search results

Breakfast does not complete successfully when it is run as a Beast. I would like to know about this failure or have it not occur. Some possibilities: Change the meaning of the preference breakfastCompleted to be breakfastCompleted successfully so the Beast failures can be detected. Not...

Welcome to the snail races. As far as I can tell the cases where the maximizer does not equip a weapon are cases where the weapon contributes nothing to whatever is being scored. So now I have to figure out why the weapon does not contribute and then decide whether that is correct or not. For...

Still here. I do not have a repeatable case - manually or via tests - where the Maximizer recommends a weapon and then it is not equipped. I have several cases where a weapon is not recommended and I believe that recommendation is correct. I have questions about the sequencing of things in...

Everything you think you know is probably wrong. I went back to the data in the OP and decided to make a test that replicated it. I thought I had done something similar but when you run out of ideas... I also unconditionally forced "2 dump" for the WEAPON slot only, whenever the code was...

I just used mirror for the first time since this was implemented. Every stinking line ends with <br> in my editor. Human readability has not been improved and my awk scripts are broken. I hope someone else is happy with this because I wasn't expecting to be happy and that prophecy was fulfilled.

As a philosophy discussion that is a good question and it is one of several areas where it things were newly done today there would be different decisions. On a practical basis the Maximizer is not something that is easily understood or changed. If I had the resources I would consider...

Well the weird slot assignment is deliberate. It is part of a scheme to keep the number of slots manageable. I keep finding examples where no weapon and weapon score the same and so no weapon is selected.

Debugger was not providing any insight. The "2, dump" from autoscend was not as helpful as I would like because I wasn't mirroring and the output did not go to the session log. But just running and dumping I notice "2, dump" is offering to put things in places where they don't belong - The...

+1 Ever the contrarian, I'm not sure about changing colors but it looks like that has already been done so...

That was awkward. I had a breakpoint where I thought a weapon had been selected. I had another where the equip command was emitted. The first fired as expected. The second didn't. So now I have to figure out the execution path and decide whether there is unnoticed or unexpected code keeping...

BetweenBattle script rather than mafia? Seems like an edge case that doesn't always have a universal solution.

Cleaned up the PR. One failing, disabled, test that I want to understand. Everything else works as expected. The new tests are probably redundant but someone can ding me on that once it goes back for review :-) Boosts are not the thing to look at if you are speculating. Once I realized that...

Current thinking and tests and a PR may change. There are two obvious causes of the maximizer being run and failing to equip a weapon. One is that the maximizer did not select a weapon. I originally thought the "effective" keyword was involved but I no longer think so. I am pretty sure I do...

Well. There is a helper, getBoosts that reports what the maximizer recommends. It turns out it references a static member of maximizer and one of my tests was incorrectly constructed as a result. Curious.

The ash 2 parameter version calls an internal 5 parameter version with zeros for the price data meaning the max price is zero and the maximizer should not consider buying. The ash 4 parameter version calls an internal 5 parameter version that interprets the third parameter as zero as meaning...

My naïve preference is that if it is in the list then its presence means I can create it by pressing the link. I don't care what I have in inventory or elsewhere. When I have no adventures I feel 'cheated" when I am offered a link to create Shore Scrip. But it does seem clear that I want to...

Found and fixed the password hash. https://github.com/kolmafia/kolmafia/pull/2203 has a single passing test added that to the best of my ability demonstrates the Maximizer selecting and equipping a weapon. I am hoping for feedback. If that test is the best we can do in a test that doesn't...

No meaningful progress. I have no confidence that my tests are exercising the equip step and the cases where no weapon is recommended seem to be correct. I've gotten distracted by looking at the Equip requests. I have a test that passes when I run it alone and fails when I run it with other...

IIRC mirror will write everything that goes to the gCLI to a named file. This sounds like there is an adjustment that is correctly computed at login but incorrectly recomputed later. modtrace at login and after it is downgraded might tell us what. I think "modtrace liver" but I'm not certain...

To be clear, why it failed to equip turtle totem is in scope of what I am working on. "Wielding turtle totem..." is the success message related to generating and submitting the equip command so it is not even clear that there was a failure to equip in your log. Why it picked turtle totem and...