Search results

Well I stripped out items and non-passive skills until the bloated test and the stripped down one have the same results. Curiously the non-passive knife skill seemed to be needed. If the weapon and off hand slots are empty they are not filled and I have not convinced myself that is...

So I have a test case that attempts to recreate the beginning of run conditions from https://kolmafia.us/threads/maximizer-didnt-equip-a-weapon.29577/page-6#post-176370 My test case is suspect in that it doesn't generate the same scores. if I were more motivated I would also investigate what...

Been there. Done that. Maybe :) See itShouldMaximizeAndEquipSelectedWeapon in RuntimeLibraryTest and the tests nested under Effective in MaximizerTest My recollection is that during test development there were identical copies of some of the tests that differed only in the presence or...

I had a couple of instances where the log was generated but they seemed to be the "This store doesn't have that item at that price. Perhaps someone beat you to it, or the shop owner changed the price of the item while you were browsing." case. Are they of interest if they happen again?

There are a few tests already committed that could be copied and modified to reproduce the above. There are at least three distinct possibilities and the difference is important because the nature of testing and fixing varies. The maximizer selects a weapon and then fails to equip it. A test...

We should discuss what a fix might be. "nothing" + offhand is the right answer in some cases. If we can ever find a case where (something + offhand) > (nothing + offhand) but the maximizer picks nothing then we have a bug that needs to be fixed. But until we find that something what we...

@Yellowbeard First, thank you for reporting. This has been a long and difficult issue to debug. The folks at autoscend graciously agreed to assist in gathering data which is why you get the messages you do. The hope is that someone will come up with a set of conditions where no weapon is...

Local test failures seemed to be caused by caching. Blew away a couple of subdirectories and everything works locally again. Looking at the effects of actually writing to disk and Swing availability on the Deck test.

Well... I decided to run the coverage reports locally since that was a quick way to find out whether the lines referenced above were executed or not. The Deck test has failed locally twice now. Go figure and stand by.

I never ran headless but once upon a time saw the deadlock a lot running with the GUI. Since my confidence level is related to tests passing/failing it is worth looking at the Deck test to see whether headless/Swing could be a factor. April 1 was an arbitrary deadline anyway. Thanks.

For reference see https://github.com/kolmafia/kolmafia/pull/1889 #1889 was a solution to preference file corruption. It appeared to address the issue so it was committed. But real world experience indicated a lot of deadlocks started occurring including one that occurred fairly consistently...

Thank you. I forgot log was there when I committed. I was failing to launch Kolmafia, could not figure out why and log captured STDOUT and STDERR from the process I launched. My mistake was in how I set up the command to run in ProcessBuilder.

New version - it does a lot of what I hoped for here. First it downloads the latest version of itself and restarts using that. It deletes older versions of itself. If the local Java version is too low for mafia it reports that and stops. Otherwise it will download the latest version of...

Hit a break point. r64 should do what previous versions did and might fix something, but probably not. Some testing and I removed some jar files that were bundled but not needed and so the jar is much smaller. There are some case sensitive bugs I need to investigate. If I actually write a...

I got some tests written and working. A side effect was that I am parsing Json in at least one place instead of using a mix of indedOf and substring. I was searching for something, could not find it and could not figure out how my search differed from what was in the file so I gave up and used...

I am writing tests. Might take a couple of days since I think I will have to relearn how to Mock classes and I know I need to make and use the equivalent of KoLmafia's root - KoLmafia/test/root Once I have tests I am going to return to some of the issues reported above. I will also consider...

Multitool's origin story is rooted in an attempt allow a user to determine whether their current version of Java was sufficient to run KoLmafia. That was me reacting to the Java nag PR. gausie suggested it could download and launch KoLmafia and that was easy to add. But now that the launcher...

I didn't use a record because I was too lazy (there's that word again) to see when they were introduced but not using one was easier than looking it up. I just got a KoLmafia test working so am resting on my laurels momentarily. multitool is not especially robust in the sense of detecting and...

*snicker* I'm fundamentally lazy, don't multi-task well and this never stays at the top of my queue for very long. Working on it is also a reminder of how far my skills and knowledge are from the current state of the art ;-) I'd love tests. I had not done them yet because I'm not sure I am...

New version. I now attempt to ignore local files that don't match the expected name convention which is ToolName-version-M.jar or ToolName-version.jar. I need to look at your failure to launch report. Any chance the multitool log file has something? I may also have incorrectly detected how...