Search results

  1. philmasterplus

    Feature - Implemented Add is_dark_mode()

    This patch adds a new ASH function: is_dark_mode(). It uses KoLmafiaGUI.isDarkTheme() to determine whether KoLmafia is using one of the FlatLaf dark themes. It also works in JavaScript as isDarkMode() This function will enable script authors to use different text colors in the gCLI for light...
  2. philmasterplus

    Bug - Fixed Incorrect drunkenness warning with base of 20.

    Thank you. I looked at your character sheet, and didn't find anything that would cause the latest revision (r20563) to fail. If I remember correctly, the bug was introduced in r20541 and should have been fixed in r20553. Since there was no change in r20563 that could have affected this, it is...
  3. philmasterplus

    Feature - Implemented Categorize HP/MP restorers in the auto-restoration panel

    It's been a few days and I've encountered no problems with the patch in reply #3. Can we have this integrated into the repo?
  4. philmasterplus

    Bug JavaScript bugs

    Ideally it should throw a TypeError exception inside the JavaScript runtime so the script author can handle it. IIRC it simply terminates the runtime.
  5. philmasterplus

    Familiar Collector/Ascension Familiar Chooser

    The original script by matt.chugg does not work due to a broken link. Here's an (experimental) rewrite in JS. It works with KoLmafia r20550 and above, so it won't work with the current EXE release (v20.7). I expect it work work for 20.8 (if it ever gets released) or later. Install with: svn...
  6. philmasterplus

    Auto-use items

    Seconding the recommendation for OCD Inventory Control. It's a great hassle to set up the big list, but it works. Don't forget to back up data/OCDData_*.txt along with your KoLmafia settings. Also, I believe from experience that the built-in cleanup routine automatically uses meat-producing...
  7. philmasterplus

    Bug - Fixed Stdlib functions are non-configurable/writable when executing JS code via gCLI

    No worries--this issue has nothing to do with sandbox breaching. It involves the question: should a script be able to shoot itself in the foot by overriding a global function? Historically, JavaScript said yes, and we've come to accept it. This patch tries to conform to that behavior...
  8. philmasterplus

    Feature Req: Integate spell restores, rest restores, and item restores into one mega-restore

    For UI stuff, we can draw a line between automation and manual control. Manual stuff: Item restores, skill restores, Daily Deeds, Travel menu. These can be activated to heal HP/MP immediately. Automated stuff: The Auto-restores panel does not heal HP/MP right away, but configures KoLmafia's...
  9. philmasterplus

    Feature - Implemented Categorize HP/MP restorers in the auto-restoration panel

    I just installed Universal Recovery and the relay page is impressive. I'm not sure if I can recreate a fraction of that in Java. Filtering for availability would be nice but require a much greater time investment. I looked at Item Manager, but it has decades of carefully written code and I dare...
  10. philmasterplus

    Feature - Implemented Categorize HP/MP restorers in the auto-restoration panel

    I'm talking about the in HP/MP Usage panel under the Adventure tab. The two lists have grown massive over the years and it is daunting. If we could separate them by type, it would be easier to manage. Items: All usable items. Includes "spleen" items, once-per-day items, and NPC store items...
  11. philmasterplus

    Bug - Fixed Stdlib functions are non-configurable/writable when executing JS code via gCLI

    Thank you. And it's fine, I don't understand half of it either. Modern JavaScript is weird.
  12. philmasterplus

    Bug - Fixed Stdlib functions are non-configurable/writable when executing JS code via gCLI

    As of r20555, the gCLI command js injects KoLmafia's stdlib functions (e.g. print(), myAdventures()) into the global scope before execution. These functions are defined as non-configurable and non-writable properties (see initRuntimeLibrary() in...
  13. philmasterplus

    BetterTrainer - Empower your guild trainer (with AoB support)

    BetterTrainer now supports Avatar of Boris! This update may cause conflicts for anyone who is using another relay override script for the Dungeoneer's Association (da.php). If you do, please let me know, and I may consider splitting this functionality into a separate script.
  14. philmasterplus

    Bug null pointer error while parsing skills

    Thank you. And I hope not. I made sure to cover everything we've seen this month. But given KoL's long history, there may be some outliers yet. I'll keep tabs on this forum, just in case.
  15. philmasterplus

    Bug - Fixed Issue with Hard Drinker in recent Daily Builds

    I posted a patch that should fix this in reply #21 of the other thread. No guarantees since I couldn't test this against any of my characters.
  16. philmasterplus

    Bug null pointer error while parsing skills

    Here's a patch that handles duplicate skill names "Static Shock" and "Hard Drinker" by using skill IDs instead of names. This patch doesn't touch CharSheetRequest.java. Fortunately, the plumber skills seem to be already covered by KoLCharacter.addAvailableSkill(), and Ferocity by...
  17. philmasterplus

    Bug null pointer error while parsing skills

    There are multiple places in KoLmafia where, in the past, we resorted to checking the character class to work around duplicate skill names. However, most of it didn't solve the issue of have_skill() thinking that the character had the wrong skill. This bug is caused by one such case. In...
  18. philmasterplus

    Bug - Fixed Issue with Hard Drinker in recent Daily Builds

    @discdeath Sorry, but you posted the source code of the main page, not the charsheet. If you're using Chrome, you'll have to right-click on the character sheet and select "View Frame Source". Then copy-n-paste the source to Notepad and save it as a text file. If done properly, the source code...
  19. philmasterplus

    Bug - Confirmed Can no longer use file_to_map to access a file contained in the KoLmafia jar

    I tried using data/coinmasters.txt instead of coinmasters.txt and it worked on r20552. @fronobulax Could you check if this works for you, too? record CoinmasterInfo { string buyOrSell; int coinAmount; item it; }; CoinmasterInfo [string] coin_masters; file_to_map("data/coinmasters.txt"...
  20. philmasterplus

    Bug null pointer error while parsing skills

    This patch fixes the issue discussed on reply #14. It should parse softcore-permed skills properly again, so that you won't see them in the "Skills You Haven't Permed Yet" list. I resorted to manually looping through next sibling nodes and checking the text content. Not ideal, but it should...
Back
Top