Search results

Ok I've got a fix for this I think.

Ah I see, we never supported Fidoxene, its just that the code that was removed supported it without us intending it to.

Looks to be related to the changes to familiar weight calculation in https://github.com/kolmafia/kolmafia/pull/846. @DanceCommander6 this might be a pain but could you post a modtrace familiar weight for both 26525 and 26525 when the issue is happening?

Welcome back hola! It's great to see you. This also reminds me of "Ctrl (or ⌘)+P" which is Command Palette in a lot of code editors. It's a great idea, we could eventually let scripts hook into it or something and add to the list of available palette commands.

I think Neil fixed this one in 719, marking fixed

This will be the fault of a refactor I did recently while testing that component. Once you force a refresh is the data shown correct? At the very least that means fixing the problem is easy!

Yeah I've been meaning to add this. I'll do so

You could document these functions with examples as java docs to the command classes if you like.

Yeah another solution is for one script author to maintain a known empty ccs and everyone else to use it as a dependency. Still seems like we could just provide something native that does that though

garbage-collector, for example, relies on replicating the behaviour described in this feature request to do exactly what you're suggesting Yes this is a convenience. It doesn't really affect script authors though, its a convenience for script users to not have loads of useless empty ccs files...

I was looking at the code and its more likely that we want a new setting for the battleAction pref to make this work

This is what I'm thinking yes

@Veracity my understanding of the requirement is as follows: Your script is running a series of fights in order by using copies. Imagine you want to submit a different macro for every fight. Because the "use" function does not accept a macro (maybe it should?) you might want to use the copy...

Fixed and merged (https://github.com/kolmafia/kolmafia/pull/587)

Fwiw - once you've visited the shop in one clan, you can change to another clan and still access it. Strange game

I have a fix PR up for this now I think

If someone can provide a debug log for when the phylum should be set in a fight but isn't, I can fix this easily.

This is off topic but in any case, why do you have so many favourited familiars?

I verified it by writing some tests! All merged now. Thanks

Honestly, I didn't know that was how it worked! This is good, except I would run that check once before the for loop! Want to submit that as a PR?