Search results

  1. H

    Bug - Not A Bug Items with numbers in their names break the maximizer

    Hm. It should be 69 "bonus pantogram pants" but you say that didn't work for you. I can't reproduce on my end, though, as that works for me with or without the quotes. Similarly, it should be +130 "bonus kol con 13 snowglobe"-- note that you should only quote the keyword, not the weight.
  2. H

    Bug semi-colons in maximizer strings

    (Said short-term workaround is only really useful in the context of scripts, which is where I noticed this breaking...)
  3. H

    Bug - Not A Bug Items with numbers in their names break the maximizer

    A better approach is to quote the "keyword", e.g. 2 meat, +"equip kol con 13 snowglobe", item This was added back in r10531.
  4. H

    Bug - Not A Bug Items with numbers in their names break the maximizer

    Cross-post from https://kolmafia.us/threads/semi-colons-in-maximizer-strings.28896/#post-172144 to let you know you can use the pilcrow to specify an item by ID. You do sacrifice readability there, and you have to know the item ID before using it, so it's not the desired long-term state.
  5. H

    Bug semi-colons in maximizer strings

    As a short-term workaround, you can specify e.g. ¶10058 for the sausage-o-matic (or similarly use the pilcrow to specify any other item by ID).
  6. H

    Bug retrieve_price is inconsistent (with Mayo items)

    Do you have autoSatisfyWithNPCs set to true?
  7. H

    Customizing relay browser chat

    I posted this some years back: https://kolmafia.us/threads/relay-chatbot-support-cli-integration-for-new-chat.15442/ Note that the crimbogrotto link is dead (web archive link), but you should still be able to browse the code on sourceforge and install it if you really want to use it. I have...
  8. H

    New Content New Shadow Rift NCs, buffs, and buff extension

    Doesn't Hunt the Wumpus do the same? (I thought Violet Fog did too, but apparently those are all different choices, just with the same name.)
  9. H

    JSON

    The above only works for me if I'm logged in, for whatever* reason. Otherwise it works just fine. * The actual reason is at the start of GenericRequest.run(). public void run() { if (GenericRequest.sessionId == null
  10. H

    Breakfast scripting: (can_interact ()) contains no comparison operator.

    Note that in ASH you can write if (can_interact) { cli_execute { briefcase collect use BittyCar SoulCar } } I couldn't find docs about this on the wiki, although I thought it was there at some point.
  11. H

    JSON

    To be fair, JSON.parse will clobber any duplicate keys before you get to that point. You shouldn't need to go through a Map -- JS Objects operate similarly to Maps (that's what we did 10 years ago, before ES2015 brought Map to the language). As MCroft mentions, I'd suggest doing some...
  12. H

    Bug Maximizer unnecessarily moves weapon to offhand

    (nit: Staff of Kitchen Royalty needs to go in the mainhand, since it's a chefstaff.) It also seems special to the June cleaver -- if I edit the mainhand to hold a time sword, it works just fine.
  13. H

    Bug Maximizer unnecessarily moves weapon to offhand

    Hm. There's a notion of "simplicity" used as part of the tiebreaker, which should prevent this. Either way, I can readily reproduce in tests, which is good for finding a fix: // https://kolmafia.us/threads/maximizer-unnecessarily-moves-weapon-to-offhand.28631/ @Test public void...
  14. H

    Bug - Fixed burn * is sometimes recovering MP to then burn it

    I believe this is fixed with r27176 but please let us know if it isn't.
  15. H

    Bug - Fixed Maximizer recommends unequipping weapon with Smithsness offhand

    Stupid fix: if (!this.calculated) { this.calculate(); this.calculate(); } In particular, there's a problem with KoLCharacter.recalculateAdjustments: it adds modifiers from enchantments, then updates Smithsness. As a result of this ordering, Smithsness is still zero when we compute bonuses...
  16. H

    Bug - Fixed burn * is sometimes recovering MP to then burn it

    FYI: Any other mechanisms for casting libram skills go through skills.php (which calls UseSkillRequest.registerRequest which sets UseSkillRequest.lastSkillId, prior to redirecting to CampgroundRequest) and don't rely on the CampgroundRequest.registerRequest -> UseSkillRequest.registerRequest...
  17. H

    Bug - Fixed burn * is sometimes recovering MP to then burn it

    I think I see the bug. CampgroundRequest.registerRequest expects summoncandyheart (etc) to be an action, while it's actually a preaction. And, in r26778, the matcher for ACTION_PATTERN was updated to make sure it didn't match preaction=... Aside: we probably shouldn't just assume that the...
  18. H

    Bug - Fixed burn * is sometimes recovering MP to then burn it

    Indeed, clicking "summon candy hearts" in the bookshelf in the campground does reproduce on my end. More to follow once I finish investigating why the current codepath is broken...
  19. H

    Attention script authors: GitHub is ending support for SVN in one year

    I can answer this one: it uses the email address associated with each commit (e.g. heeheehee <heeheehee@users.sourceforge.net>), and looks to see if there's an account there. Some instructions from gausie when we were doing the migration:
  20. H

    KeepingTabs - a simple inventory management script

    According to the actual repo, try: git checkout https://github.com/loathers/keeping-tabs.git release
Back
Top