Search results

@fronobulax raised some points in the pull request that I feel warrant more discussion / visibility. @ikzann @Ryo_Sangnoir The obvious place where faster JSON might be relevant is in parsing api.php, but it's also not clear to me that JSON handling is a bottleneck at this time. It's also not...

Hm. For the next time this happens again, mind grabbing a debug log at the start of your session, then again right after it occurs? Specifically, debug on; text game.php; debug off should be enough to grab some response headers, which'll tell us which version of nginx is issuing the GOAWAY...

KoL is apparently using both nginx/1.18.0 and nginx/1.8.1, per the returned headers (the AWSALB cookie pins you to a particular backend). Perhaps they've recently started a migration, which would explain why this started happening again. (HTTP/2 support in nginx was added in 1.9.5.)...

That said, r26388 implemented the nominal "reset the HttpClient every X requests" (which was later refined in r27798). I would be a little surprised if we're running into the headers-too-big problem. I'd be more inclined to believe that something isn't actually using the ResettingHttpClient.

If that were the case, then ~every request would result in a GOAWAY. We do not have our own hand-rolled HTTP codec, as we're relying on Java's standard library implementation. As such, I'm very skeptical of the notion that Mafia is doing something that's standards-noncompliant. We have seen...

As xKiv points out, you're probably best off updating Mafia to a more recent build. That said... The passwords are stored in settings/GLOBAL_prefs.txt as saveState.<your username> as a number, after having gone through a couple of encoding steps. Let's suppose you find...

It looks like the URL has moved to https://museum.loathers.net/api/player/2115655?routes/player.$id._index (as @Ryo_Sangnoir pointed out in May) let kolmafia = require("kolmafia") let results = {}; for (let playerId of [1, 354981]) { let url =...

Hm. I wonder if this is related to being locked in a chain of choice adventures at the time we're trying to refresh our list of skills.

I don't suppose you can share any maximization strings or details re: exactly what got equipped when? If you can find a sequence of actions (beyond "run a specific script that adventures and otherwise depends a lot on current player state") that reproduces the bad state consistently from a...

Anyways, let us know if you still see this problem with r28033 (or later). I can't test readily because I don't think I have access to an account with > 2 billion meat on hand.

CharSheetRequest still uses StringUtilities.parseInt in this and a few related contexts, which results in clobbering the value we parse from api.php / charpane.php. edit: https://github.com/kolmafia/kolmafia/pull/2416

I see the same error on r28030 (i.e. before my dependency bump). It seems nominally benign, although I believe it's tied to the greclipse() line in the spotless stanza.

I saw that too. It's probably related to at least one of the dependencies I bumped. When I tried upgrading spotless, that yielded some actual diffs, so I held off for the time being. I'll look into it some more.

https://github.com/kolmafia/kolmafia/pull/2413

> NOTE: This plugin changed the core maintainer and has new coordinates:https://plugins.gradle.org/plugin/com.gradleup.shadow https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow I'll send a PR in a bit.

Looks like the shadow plugin. https://github.com/GradleUp/shadow/issues/924

I make no promises about the attached file (slightly edited source plus exe), but it seems to run just fine for me using various compatibility tools on Linux. I continue to have no real experience with C#. (edit: this apparently lost matt.chugg's change to enable TLS 1.2 back on page 8. If for...

I forgot that I had a branch that tinkered with this, but I've now created https://github.com/kolmafia/kolmafia/pull/2381.

I upgraded Gradle to 8.8, and Spotless no longer finds any violations with openjdk21. However, I'm seeing several test failures due to Mockito being unable to mock certain standard library classes. It seems that for some strange reason, mockito-inline in the central maven repo is stuck on 5.2.0...

IMO, debug logs should not be generated by a script unless there really is a bug in Mafia. That said, my inclination would be to make any function call from JS to ASH that passes an unrepresentable value to throw a JS exception, rather than passing null to some ASH function (whether...