Search results

  1. Rinn

    Feature - Implemented retrieve_price is too noisy

    They're seeing cli output like this when running a diet planning script ===== SHOTGLASS DIET ===== Planning to fight 67 embezzlers and run 463 adventures 1 (max 1) astral pilsner value: 68200 price: 0 Assuming MPA of 6200, Total Cost 0, Total Value 68200, Net Value 68200 Trying to acquire 0...
  2. Rinn

    Bug - Fixed Java Bug: On some versions of Java, weird things happen to strings with special characters

    It would appear so, my test script doesn't error any more.
  3. Rinn

    Bug - Fixed Java Bug: On some versions of Java, weird things happen to strings with special characters

    This can be minimally reproduced with a .js script that contains module.exports.main = function() { require("kolmafia").Item.get("Our Daily Candles™ order form") }
  4. Rinn

    New Content Security Scan

    But imo since this isn't really publicly accessible server app it probably doesn't really matter.
  5. Rinn

    New Content Security Scan

    You would need to look at the entire call path, getAdventureId() is using form data to return the string and that's where the warning is rooted from.
  6. Rinn

    Feature mallprices.txt override data, caching, & sharing considerations

    https://github.com/kolmafia/kolmafia/pull/687
  7. Rinn

    Feature mallprices.txt override data, caching, & sharing considerations

    Okay all that all makes sense, I would personally like to see MALL_PRICE_AGE is taken into account more often to use the cached price, rather than doing a mall search even for standard normal mall_price calls but I understand why it doesn't work that way. MALL_PRICE_AGE should probably at least...
  8. Rinn

    Feature mallprices.txt override data, caching, & sharing considerations

    I wanted to get opinions on mallprices.txt since this was an unintended side effect to the git migration and the change I made when I removed support for the manual point releases in favor of the automated builds every git commit, the version string used to only change for point releases where...
  9. Rinn

    Free Fights Script

    Also those get_it functions are unnecessary, retrieve_item counts items in your inventory already when determining how many to acquire.
  10. Rinn

    Free Fights Script

    $item[Red Zeppelin ticket].to_int() returns the item id, not the number in your inventory. You want .item_amount()
  11. Rinn

    Feature - Implemented int retrieve_cost(item) function to get the meat required to acquire the supplied item

    I was wrong about valueOfInventory, if it's 1.0 or less it uses the autosell price, it only checks the mall if it's greater than 1 and then subtracts 1 from valueOfInventory before using it as a multiplier, so unintuitively it has to be set to 2.0 to match the mall price. I'm not sure why the...
  12. Rinn

    r26226 - feat: add blind snake by @midgleyc in

    Looks like it's an unused monster from an unimplemented pirate realm zone. It has factoids.
  13. Rinn

    Excavator - gausie's spading script

    autoscend is calling the mafia command `spade` in auto_bedtime.ash, which loops though the spadingData variable and prompts you to confirm before sending each kmail. You can call `spade autoconfirm` and mafia won't prompt you.
  14. Rinn

    BeachComber - fast and efficient beach combing

    Gausie has a kol account `excavator` the kmails are sent to and it pulls that data and posts it to a google sheet https://github.com/gausie/excavator
  15. Rinn

    BeachComber - fast and efficient beach combing

    This is in excavator now btw.
  16. Rinn

    Feature - Implemented int retrieve_cost(item) function to get the meat required to acquire the supplied item

    r26205. Implemented as retrieve_price, takes the same args as retrieve_item. I recommend setting valueOfInventory to 1.0 so it treats your inventory items as having the same value as buying them.
  17. Rinn

    Excavator - gausie's spading script

    Few updates recently: Removed: WLF Bunker. It was decided there's no discernable pattern of the requests Added: Beach combing rarity Added: Beach combing twinkling tiles
  18. Rinn

    Feature - Implemented int retrieve_cost(item) function to get the meat required to acquire the supplied item

    Yeah I think this is fine, it's using the mall value from StoreManager.getMallPrice() internally just like the mall_price ash function is. I can make a PR. The only thing that might be a little confusing is the interaction with items being in your inventory already and also it considers...
  19. Rinn

    Feature - Implemented int retrieve_cost(item) function to get the meat required to acquire the supplied item

    I think this is just what InventoryManager.priceToAcquire() returns already and could be exposed as an ash func?
  20. Rinn

    BeachComber - fast and efficient beach combing

    My thought was to have a spadingScript handle the logging so it fires regardless of how the beach was combed, for example: https://github.com/gausie/excavator/pull/40
Back
Top