Issue with constant messages wrt deprecated preference

Ever since this commit, every time anything is logged in the cli, this gets appended to it:

Warning: Preference '_summonResortPassUsed' is deprecated. Use numeric _summonResortPassesUsed instead

Click to expand...

Now I get that this is to alert some script writer (not sure which script that would be for me) to fix their scripts and that hence this is not a bug per se, but it really feels very spammy to me and my logs. Is there a way to filter this via logPreferenceChangeFilter?

This is most likely coming from any one of the loathers scripts, due to https://github.com/loathers/libram/blob/main/src/propertyTypes.ts#L2 which in turn is autogenerated from all of the properties per the comment on line 1.

I think the easiest workaround on our side is to remove it from defaults.txt, since it is deprecated and we probably don't want to keep recreating it in new installations. That'll take some time to propagate downstream, but I expect one of the owners there can manually trigger the (every-two-weeks) github action to pick it up sooner.

Hm, but the deprecation warning is configured in defaults.txt. I suppose it wouldn't be too bad if libram checked for the deprecated attribute and stopped populating that.

That said, I also see an explicit reference in https://github.com/loathers/TourGuide/blob/main/Source/relay/TourGuide/Sets/Skills.ash#L209 which may be more relevant.

@gausie asserts that this was being caused by Mafia code (possibly related to the daily deeds manager, if I had to guess?), and that this should be fixed by r28615.

It didn't fix it, and yeah, it only seems to happen when tourguide is running.
I'm code stupid, so have no idea. It sure triggers a CLI watcher, though.

Well, I sent them https://github.com/loathers/TourGuide/pull/256 so we'll see when that gets merged.